PEP 590: Mark the main API as private to allow changes in Python 3.9 - #1064

Merged

encukou merged 5 commits into

python:masterfrom

encukou:pep590-private

May 28, 2019

encukou commented May 21, 2019

Member

cc @markshannon @jdemeyer

PEP 590: Mark the main API as private to allow changes in Python 3.9

1d8b796

the-knights-who-say-ni added the CLA signed label

encukou mentioned this pull request

PEP 590: new function PyObject_VectorcallDict #1057

Closed

jdemeyer reviewed

View reviewed changes

pep-0590.rst Outdated

jdemeyer commented May 21, 2019

Contributor

_vectorcallfunc really should be private too.

encukou commented May 21, 2019

MemberAuthor

vectorcallfunc is only usable with _Py_TPFLAGS_HAVE_VECTORCALL, so users will get the warning that they're using unfinalized API. I don't think it needs to be underscore-prefixed.

Move "Finalizing the API" section after "New C API"

cb45bd8

jdemeyer reviewed

View reviewed changes

pep-0590.rst Outdated

Clarify what the plan for old names is

84c9135

jdemeyer commented May 21, 2019

Contributor

vectorcallfunc is only usable with _Py_TPFLAGS_HAVE_VECTORCALL, so users will get the warning that they're using unfinalized API. I don't think it needs to be underscore-prefixed.

OK, I see what you mean.

jdemeyer reviewed

View reviewed changes

pep-0590.rst Outdated

jdemeyer reviewed

View reviewed changes

pep-0590.rst Outdated

jdemeyer reviewed

View reviewed changes

pep-0590.rst Outdated

jdemeyer reviewed

View reviewed changes

pep-0590.rst Outdated

jdemeyer commented May 21, 2019

Contributor

I have no further comments.

encukou added 2 commits

May 21, 2019 11:05

Address review comments

6ccba2b

Typo fix: "the the"

999f399

encukou requested a review from markshannon

May 21, 2019 10:25

jdemeyer mentioned this pull request

PEP 590: Use size_t for "number of arguments + flag" #1066

Merged

encukou merged commit 8363d1f into python:master

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment