Skip to content

PEP 1: Relax CODEOWNERS rule to allow PEP editors to "own" PEPs - #2252

Merged
AA-Turner merged 7 commits into
python:mainfrom
AA-Turner:pep-1-relax-codeowners
Jan 20, 2022
Merged

PEP 1: Relax CODEOWNERS rule to allow PEP editors to "own" PEPs#2252
AA-Turner merged 7 commits into
python:mainfrom
AA-Turner:pep-1-relax-codeowners

Conversation

@AA-Turner

@AA-TurnerAA-Turner commented Jan 20, 2022

Copy link
Copy Markdown
Member

@AA-TurnerAA-Turner mentioned this pull request Jan 20, 2022
Merged
@CAM-Gerlach

CAM-Gerlach commented Jan 20, 2022

Copy link
Copy Markdown
Member

Yeah, it certainly seems like a simple oversight to me; PEP 1 may not have envisioned PEP editors who weren't core developers, like you, me and @JelleZijlstra are today. This affects you too on PEP 676, and @JelleZijlstra is already listed as CODEOWNER on PEP 673 and PEP 675, so it seems worth clarifying (even if, I think, we all understand the intent of it).

@CAM-Gerlach
CAM-Gerlach requested a review from a teamJanuary 20, 2022 05:02
@AA-Turner

AA-Turner commented Jan 20, 2022

Copy link
Copy Markdown
MemberAuthor

Build failed due to reST typo, now fixed.

JelleZijlstra
JelleZijlstra approved these changes Jan 20, 2022
View reviewed changes

@JelleZijlstraJelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2112 is where we generally approved PEP editors as sponsors. This is consistent with that change.

CAM-Gerlach
CAM-Gerlach approved these changes Jan 20, 2022
View reviewed changes

@CAM-GerlachCAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small textual suggestions; otherwise ✔️ from me

Comment threadpep-0001.txt Outdated
Comment threadpep-0001.txt Outdated
CAM-Gerlach
CAM-Gerlach reviewed Jan 20, 2022
View reviewed changes
Comment threadpep-0001.txt Outdated
@AA-TurnerAA-Turner changed the title Relax CODEOWNERS rule to allow PEP editors to "own" PEPsPEP 1: Relax CODEOWNERS rule to allow PEP editors to "own" PEPsJan 20, 2022
@AA-Turner

AA-Turner commented Jan 20, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

We've three PEP editors approving, I'll wait until tomorrow afternoon (~4pm UTC, 20/01) and merge if there's no negative comments

A

@Rosuav

Rosuav commented Jan 20, 2022

Copy link
Copy Markdown
Contributor

I wonder if the last sentence might be less awkward as "sponsor/co-author(s) are added"? The singular/plural discrepancy is hard to handle, but maybe combining them might feel better.

@CAM-Gerlach

CAM-Gerlach commented Jan 20, 2022

Copy link
Copy Markdown
Member

Great suggestion @Rosuav ; this also bypasses the "and"/"or" issue I was haggling over

CAM-Gerlach
CAM-Gerlach reviewed Jan 20, 2022
View reviewed changes
Comment threadpep-0001.txt Outdated
@AA-Turner@Rosuav
Plural agreement
d5c3645
Co-authored-by: Chris Angelico <rosuav@gmail.com>
@AA-Turner
AA-Turner merged commit b16058c into python:mainJan 20, 2022
@AA-Turner

AA-Turner commented Jan 20, 2022

Copy link
Copy Markdown
MemberAuthor

Thanks all for the reviews, merged
A

@erlend-aaslanderlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aaslanderlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RosuavRosuavRosuav left review comments
@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes
@CAM-GerlachCAM-GerlachCAM-Gerlach approved these changes
@ncoghlanncoghlanAwaiting requested review from ncoghlan
@warsawwarsawAwaiting requested review from warsaw

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AA-Turner@CAM-Gerlach@Rosuav@JelleZijlstra@the-knights-who-say-ni