Skip to content

PEP 594: Apply typofixes & language tweaks - #2334

Merged
brettcannon merged 3 commits into
python:mainfrom
bskinn:patch-2
Feb 16, 2022
Merged

PEP 594: Apply typofixes & language tweaks#2334
brettcannon merged 3 commits into
python:mainfrom
bskinn:patch-2

Conversation

@bskinn

@bskinnbskinn commented Feb 16, 2022

Copy link
Copy Markdown
Contributor

Just a few things I noticed on my read-through.

@bskinn
Apply typofixes & language tweaks to PEP 594
9aac019
Just a few things I noticed on my read-through.
CAM-Gerlach
CAM-Gerlach reviewed Feb 16, 2022
View reviewed changes

@CAM-GerlachCAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor further tweaks, otherwise LGTM. Thanks @bskinn !

Comment threadpep-0594.rst Outdated
Comment threadpep-0594.rst Outdated
Comment threadpep-0594.rst Outdated
@bskinn@CAM-Gerlach
PEP 594:Apply suggested further edits from code review
8ba0ef6
Adds two missing commas and rewords the 'these packages are no longer slated for deprecation' language -- thanks, @CAM-Gerlach!
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
JelleZijlstra
JelleZijlstra reviewed Feb 16, 2022
View reviewed changes
Comment threadpep-0594.rst
@hugovk

hugovk commented Feb 16, 2022

Copy link
Copy Markdown
Member

The Post-History at the top needs updating too:

Post-History: 21-May-2019

PEP 1:

 Post-History: <dates of postings to python-ideas and/or python-dev>

What is/are the new dates?

It was posted to Discourse on 4th Feb:

https://discuss.python.org/t/pep-594-take-2-removing-dead-batteries-from-the-standard-library/13508

(We probably need to include Discourse in PEP 1 too.)

@bskinn

bskinn commented Feb 16, 2022

Copy link
Copy Markdown
ContributorAuthor

@hugovk Would that be better fixed in a separate PR?

I had opened this one intending it not to change anything substantial.

@bskinn
Add further fixes
8dbc34e
- Harmonize header capitalization
- Add ``parser`` code formatting
- Add whitespacelines under "Update #" headers for consistency.
@CAM-Gerlach

CAM-Gerlach commented Feb 16, 2022

Copy link
Copy Markdown
Member

(We probably need to include Discourse in PEP 1 too.)

See #2266 ; a PR to implement what was discussed there is pending merge of #2302 , to avoid the chance of conflicts

I had opened this one intending it not to change anything substantial.

I'd consider that a pretty minor change, but I agree its out of scope here in a copyediting/proofreading PR. The discussion link should be updated as well; I can do that in a separate PR.

@bskinn

bskinn commented Feb 16, 2022

Copy link
Copy Markdown
ContributorAuthor

I'd consider that a pretty minor change, but I agree its out of scope here in a copyediting/proofreading PR.

Agreed that it's minor, but it seems like choosing the correct date to put there may take some discussion, which would probably be better sited with/near related discussion.

@CAM-GerlachCAM-Gerlach mentioned this pull request Feb 16, 2022
Merged
@CAM-Gerlach

CAM-Gerlach commented Feb 16, 2022

Copy link
Copy Markdown
Member

PR opened as #2335 to update the Discourse link and post date

it seems like choosing the correct date to put there may take some discussion

I'm not sure how it is ambiguous, given its just the date that the new Discourse thread was posted (and not terribly critical regardless), but I do agree it is not really in scope here and would be better handled in a separate PR, which I've opened as above.

@bskinn

bskinn commented Feb 16, 2022

Copy link
Copy Markdown
ContributorAuthor

I'm not sure how it is ambiguous ...

Had just never noticed that the Post-History field could hold more than one date. 🙂

CAM-Gerlach
CAM-Gerlach approved these changes Feb 16, 2022
View reviewed changes

@CAM-GerlachCAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks @bskinn !

@CAM-Gerlach

CAM-Gerlach commented Feb 16, 2022•
edited
Loading

Copy link
Copy Markdown
Member

@brettcannon I assume you'll want to look this over and merge, since this is your PEP?

@brettcannon
brettcannon merged commit fc3eb21 into python:mainFeb 16, 2022
@brettcannon

brettcannon commented Feb 16, 2022

Copy link
Copy Markdown
Member

@CAM-Gerlach 🤷 there's no semantic change here, so no need to wait on me specifically.

@brettcannon

brettcannon commented Feb 16, 2022

Copy link
Copy Markdown
Member

@bskinn thanks for the PR!

@bskinn
bskinn deleted the patch-2 branch February 16, 2022 22:36
@erlend-aaslanderlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aaslanderlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments
@brettcannonbrettcannonbrettcannon approved these changes
@CAM-GerlachCAM-GerlachCAM-Gerlach approved these changes
@tirantiranAwaiting requested review from tiran

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bskinn@hugovk@CAM-Gerlach@brettcannon@JelleZijlstra@the-knights-who-say-ni