Skip to content

PEP 683: Immortal Objects v3 - #2372

Merged
ericsnowcurrently merged 26 commits into
python:mainfrom
ericsnowcurrently:immortal-objects-v3
Mar 1, 2022
Merged

PEP 683: Immortal Objects v3#2372
ericsnowcurrently merged 26 commits into
python:mainfrom
ericsnowcurrently:immortal-objects-v3

Conversation

@ericsnowcurrently

@ericsnowcurrentlyericsnowcurrently commented Feb 28, 2022

Copy link
Copy Markdown
Member

This is mostly changes in response to https://mail.python.org/archives/list/python-dev@python.org/thread/KDAR6CCMPOX36GQJUDWHQBKRD5USNV3B/. Also, we increase the focus on the immutability of per-object runtime state.

@ericsnowcurrently

ericsnowcurrently commented Feb 28, 2022

Copy link
Copy Markdown
MemberAuthor

@eduardo-elizondo

JelleZijlstra
JelleZijlstra requested changes Feb 28, 2022
View reviewed changes

@JelleZijlstraJelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments.

Comment threadpep-0683.rst Outdated
Comment threadpep-0683.rst Outdated
Comment threadpep-0683.rst Outdated
Comment threadpep-0683.rst Outdated
ericsnowcurrentlyand others added 3 commits February 28, 2022 15:11
@ericsnowcurrently@JelleZijlstra
Fix a typo.
a6d07a4
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@ericsnowcurrently@JelleZijlstra
Fix a typo.
5b2fe45
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@ericsnowcurrently@JelleZijlstra
Fix a typo.
8188ae5
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
AA-Turner
AA-Turner reviewed Feb 28, 2022
View reviewed changes
Comment threadpep-0683.rst Outdated
Comment threadpep-0683.rst Outdated
Comment threadpep-0683.rst
@AA-TurnerAA-Turner changed the title [PEP 683] Immortal Objects v3PEP 683: Immortal Objects v3Feb 28, 2022
@AA-Turner

AA-Turner commented Feb 28, 2022

Copy link
Copy Markdown
Member

Thanks both, looks good!

A

@ericsnowcurrently

ericsnowcurrently commented Mar 1, 2022

Copy link
Copy Markdown
MemberAuthor

@eduardo-elizondo, I'm going to merge this (and post to python-dev) soon unless you have any changes to include.

eduardo-elizondo
eduardo-elizondo approved these changes Mar 1, 2022
View reviewed changes

@eduardo-elizondoeduardo-elizondo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just went through all the changes. Huge thumbs up on my end, this definitely clarifies a bunch of the points that have been brought up in the various python-dev threads as well as leaving the implementation details open enough to keep iterating and improving this over time as long the initial change is close to perf neutral.

eduardo-elizondo
eduardo-elizondo reviewed Mar 1, 2022
View reviewed changes
Comment threadpep-0683.rst
@ericsnowcurrently
ericsnowcurrently merged commit 0a6375d into python:mainMar 1, 2022
@ericsnowcurrently
ericsnowcurrently deleted the immortal-objects-v3 branch March 1, 2022 00:55
@erlend-aaslanderlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aaslanderlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes
@AA-TurnerAA-TurnerAA-Turner approved these changes
+1 more reviewer
@eduardo-elizondoeduardo-elizondoeduardo-elizondo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ericsnowcurrently@AA-Turner@JelleZijlstra@eduardo-elizondo@the-knights-who-say-ni