Uh oh!
There was an error while loading. Please reload this page.
PEP 630: Format and copyedit prior to conversion into a docs HOWTO guide - #2459
Conversation
encukou
left a comment
There was a problem hiding this comment.
Thank you!
If you don't mind me asking, what's the main thing you'd change for a major rewrite?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ef73c09 to
637448eCompareCAM-Gerlach
commented
Apr 15, 2022
Updating to retrigger the CLA bot
Sorry, I meant to reply to this but must have never submitted it, and its been so long I've forgotten what I was going to say other than restructuring it to be framed more as a guide, which would presumably be done when it is moved. |
CAM-Gerlach
commented
Apr 15, 2022
@encukou can we merge this, or anything else you'd like to change at this point? |
CAM-Gerlach
commented
Apr 19, 2022
Hey @encukou , any final thoughts on this one? |
encukou
commented
Apr 19, 2022
Well, the restructuring you mentioned :) Thank you for the editing! |
CAM-Gerlach
commented
Apr 19, 2022
Thank you for your kind words and encouraging me to! |
As originally requested by @encukou in #2450 .
Overall, the base prose quality of the document was very good, so there weren't that many changes necessary to begin with, without doing a major rewrite (when there are certainly bigger fish to fry in that department).
In general, I attempted to keep my changes fairly unobtrusive. There were only a few non-purely-copyediting additions that affect content/meaning, the only really significant was was adding a mention of PEP 683 (PEP-0683), which relates directly to the note on immutable objects not being truly immutable due to the refcount.