Skip to content

PEP 688: Making the buffer protocol accessible in Python - #2549

Merged
JelleZijlstra merged 18 commits into
python:mainfrom
JelleZijlstra:bufferpep
Apr 25, 2022
Merged

PEP 688: Making the buffer protocol accessible in Python#2549
JelleZijlstra merged 18 commits into
python:mainfrom
JelleZijlstra:bufferpep

Conversation

@JelleZijlstra

@JelleZijlstraJelleZijlstra commented Apr 23, 2022

Copy link
Copy Markdown
Member

No description provided.

@JelleZijlstra
JelleZijlstra requested a review from a team as a code ownerApril 23, 2022 16:48
AA-Turner
AA-Turner reviewed Apr 23, 2022
View reviewed changes

@AA-TurnerAA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two uses of "I" which I've suggested turning into plural or neutral language as the rest of the document seems to use "we".

A couple of small suggestions elsewise.

A

Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
@CAM-GerlachCAM-Gerlach added the new-pep A new draft PEP submitted for initial review label Apr 23, 2022
@CAM-Gerlach

CAM-Gerlach commented Apr 23, 2022

Copy link
Copy Markdown
Member

Hey @JelleZijlstra , would you like me to proofread and suggest copyedits on this?

@JelleZijlstra

JelleZijlstra commented Apr 24, 2022

Copy link
Copy Markdown
MemberAuthor

@CAM-Gerlach yes please! Can't guarantee I'll agree with all your suggestions though :)

@JelleZijlstraJelleZijlstra mentioned this pull request Apr 24, 2022
Closed
CAM-Gerlach
CAM-Gerlach reviewed Apr 24, 2022
View reviewed changes

@CAM-GerlachCAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go! In a lot of places, I provided multiple different possible options for you to consider that resolved an issue, if you didn't like the first one (or I myself had no strong preference).

Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Fidget-Spinner
Fidget-Spinner reviewed Apr 24, 2022
View reviewed changes
Comment threadpep-0688.rst
AlexWaygood
AlexWaygood reviewed Apr 24, 2022
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited to see this happen! A few thoughts from me below :)

Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst
Comment threadpep-0688.rst Outdated
AlexWaygood
AlexWaygood reviewed Apr 24, 2022
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more small points :)

Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
Comment threadpep-0688.rst Outdated
AlexWaygood
AlexWaygood approved these changes Apr 25, 2022
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me :)

@JelleZijlstra
JelleZijlstra merged commit 0cb0066 into python:mainApr 25, 2022
@JelleZijlstra
JelleZijlstra deleted the bufferpep branch April 25, 2022 03:39
@JelleZijlstra

JelleZijlstra commented Apr 25, 2022

Copy link
Copy Markdown
MemberAuthor

Thanks everyone for the feedback! I just merged the PR so it shows up on the official site. If you have further textual suggestions, feel free to put a note here, open a PR, give me a handwritten note at PyCon, or let me know in whatever other way you can think of.

@gvanrossum

gvanrossum commented Apr 25, 2022

Copy link
Copy Markdown
Member

Carrier pigeon.

@CAM-Gerlach

CAM-Gerlach commented Apr 25, 2022

Copy link
Copy Markdown
Member

Interpretive dance.

@erlend-aaslanderlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aaslanderlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-TurnerAA-TurnerAA-Turner left review comments
@CAM-GerlachCAM-GerlachCAM-Gerlach left review comments
@Fidget-SpinnerFidget-SpinnerFidget-Spinner left review comments
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

new-pepA new draft PEP submitted for initial review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@JelleZijlstra@CAM-Gerlach@gvanrossum@AA-Turner@Fidget-Spinner@AlexWaygood@hauntsaninja