Skip to content

Add Typing Topic - #2670

Merged
JelleZijlstra merged 7 commits into
python:mainfrom
JelleZijlstra:topictyping
Oct 7, 2022
Merged

Add Typing Topic#2670
JelleZijlstra merged 7 commits into
python:mainfrom
JelleZijlstra:topictyping

Conversation

@JelleZijlstra

@JelleZijlstraJelleZijlstra commented Jun 25, 2022

Copy link
Copy Markdown
Member

No description provided.

CAM-Gerlach
CAM-Gerlach reviewed Jun 25, 2022
View reviewed changes
Comment threadpep_sphinx_extensions/pep_zero_generator/constants.py Outdated
@JelleZijlstra@CAM-Gerlach
Update pep_sphinx_extensions/pep_zero_generator/constants.py
613c27c
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@JelleZijlstra
JelleZijlstra marked this pull request as ready for review July 1, 2022 15:13
CAM-Gerlach
CAM-Gerlach reviewed Jul 2, 2022
View reviewed changes

@CAM-GerlachCAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least in the packaging PEPs, we put the Topic below the Type, which seems to make sense, so probably worth being consistent here like the other headers are.

Also, one wording suggestion.

Comment threadpep-0482.txt Outdated
Comment threadpep_sphinx_extensions/pep_zero_generator/constants.py
@CAM-GerlachCAM-Gerlach added enhancement meta Related to the repo itself and its processes labels Jul 2, 2022
@CAM-GerlachCAM-Gerlach changed the title Add typing TopicAdd Typing TopicOct 7, 2022
CAM-Gerlach
CAM-Gerlach approved these changes Oct 7, 2022
View reviewed changes

@CAM-GerlachCAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now; thanks @JelleZijlstra

@JelleZijlstra
JelleZijlstra merged commit 83b976d into python:mainOct 7, 2022
@JelleZijlstra
JelleZijlstra deleted the topictyping branch October 7, 2022 00:36
@hugovk

hugovk commented Oct 7, 2022

Copy link
Copy Markdown
Member

And it's live!

https://peps.python.org/topic/typing/

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-GerlachCAM-GerlachCAM-Gerlach approved these changes
@gvanrossumgvanrossumAwaiting requested review from gvanrossum
@larryhastingslarryhastingsAwaiting requested review from larryhastings
@ilevkivskyiilevkivskyiAwaiting requested review from ilevkivskyi
@ambvambvAwaiting requested review from ambv
@lisroachlisroachAwaiting requested review from lisroach
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

No one assigned

Labels

enhancementmetaRelated to the repo itself and its processes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JelleZijlstra@hugovk@CAM-Gerlach