Skip to content

enable netlify - #2912

Closed
ewdurbin wants to merge 2 commits into
mainfrom
netlify
Closed

enable netlify#2912
ewdurbin wants to merge 2 commits into
mainfrom
netlify

Conversation

@ewdurbin

Copy link
Copy Markdown
Member

No description provided.

@ewdurbin
ewdurbin requested review from a team and AA-Turner as code ownersDecember 6, 2022 13:46
@netlify

netlifyBot commented Dec 6, 2022

Copy link
Copy Markdown

Deploy Preview for python-peps-preview failed.

NameLink
🔨 Latest commit166e224
🔍 Latest deploy loghttps://app.netlify.com/sites/python-peps-preview/deploys/638f4b98cccd010009205aba

@ewdurbin

Copy link
Copy Markdown
MemberAuthor

Not sure what's up... seems it might be an incompatibility with python3.8 (best available on netlify)

@AA-Turner

Copy link
Copy Markdown
Member

I don't think PEPs need Netlify, as we already have render previews. Is there a reference to the discussion for this at all?

A

@ewdurbin

Copy link
Copy Markdown
MemberAuthor

wires crossed here, I read that as CAM asking for netlify here #2875 (review)

@ewdurbinewdurbin closed this Dec 6, 2022
@ewdurbin
ewdurbin deleted the netlify branch December 6, 2022 14:19
@AA-Turner

Copy link
Copy Markdown
Member

No worries, thank you--good that the CPython previews are now enabled.

A

@CAM-Gerlach

Copy link
Copy Markdown
Member

Sorry for the confusion, and thanks for taking care of that—it will be a huge benefit there to both PR authors and reviewers alike!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ewdurbin@AA-Turner@CAM-Gerlach