Skip to content

Infra: Update precommit to fix Poetry - #2994

Merged
hugovk merged 1 commit into
python:mainfrom
hugovk:update-precommit
Jan 31, 2023
Merged

Infra: Update precommit to fix Poetry#2994
hugovk merged 1 commit into
python:mainfrom
hugovk:update-precommit

Conversation

@hugovk

Copy link
Copy Markdown
Member

Re: PyCQA/isort#2078

Fixes lint errors such as https://github.com/python/peps/actions/runs/4051441599/jobs/6969773973 in #2993:

[INFO] Installing environment for https://github.com/PyCQA/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/home/runner/.cache/pre-commit/repo0jaa0x15/py_env-python3/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
Processing /home/runner/.cache/pre-commit/repo0jaa0x15
Installing build dependencies: started
Installing build dependencies: finished with status 'done'
Getting requirements to build wheel: started
Getting requirements to build wheel: finished with status 'done'
Preparing metadata (pyproject.toml): started
Preparing metadata (pyproject.toml): finished with status 'error'
stderr:
error: subprocess-exited-with-error
× Preparing metadata (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [17 lines of output]
Traceback (most recent call last):
File "/home/runner/.cache/pre-commit/repo0jaa0x15/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 351, in <module>
main()
File "/home/runner/.cache/pre-commit/repo0jaa0x15/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 333, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/.cache/pre-commit/repo0jaa0x15/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 152, in prepare_metadata_for_build_wheel
return hook(metadata_directory, config_settings)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/pip-build-env-klr2dol8/overlay/lib/python3.11/site-packages/poetry/core/masonry/api.py", line 40, in prepare_metadata_for_build_wheel
poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/pip-build-env-klr2dol8/overlay/lib/python3.11/site-packages/poetry/core/factory.py", line 57, in create_poetry
raise RuntimeError("The Poetry configuration is invalid:\n" + message)
RuntimeError: The Poetry configuration is invalid:
- [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
hint: See above for details.
Check the log at /home/runner/.cache/pre-commit/pre-commit.log
Error: Process completed with exit code 3.

@hugovkhugovk added the infra Core infrastructure for building and rendering PEPs label Jan 31, 2023

@CAM-GerlachCAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hugovk

@CAM-GerlachCAM-Gerlach added lint Linter-related work and linting fixes on PEPs and removed infra Core infrastructure for building and rendering PEPs labels Jan 31, 2023
@hugovk
hugovk merged commit b6ac1fa into python:mainJan 31, 2023
@hugovk
hugovk deleted the update-precommit branch January 31, 2023 08:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lintLinter-related work and linting fixes on PEPs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk@hauntsaninja@CAM-Gerlach