Skip to content

PEP 1 and 12: Document Topic header - #2995

Merged
hugovk merged 7 commits into
python:mainfrom
hugovk:meta-add-topic-to-peps-1-and-12
Feb 3, 2023
Merged

PEP 1 and 12: Document Topic header#2995
hugovk merged 7 commits into
python:mainfrom
hugovk:meta-add-topic-to-peps-1-and-12

Conversation

@hugovk

@hugovkhugovk commented Jan 31, 2023

Copy link
Copy Markdown
Member

Document the Topic header in PEPs 1 and 12.

As suggested by @warsaw in #2986 (comment).

The Governance topic will be added in #2993.

@hugovkhugovk mentioned this pull request Jan 31, 2023
Merged
warsaw
warsaw approved these changes Jan 31, 2023
View reviewed changes

@warsawwarsaw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with comment

Comment threadpep-0001.txt Outdated
CAM-Gerlach
CAM-Gerlach reviewed Feb 1, 2023
View reviewed changes

@CAM-GerlachCAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should also be added to the header listing under How to use this template in PEP 12, and maybe also as a short bullet point there.

Comment threadpep-0001.txt Outdated
Comment threadpep-0001.txt Outdated
hugovkand others added 2 commits February 1, 2023 18:46
@hugovk@CAM-Gerlach
Review updates
d33389e
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@hugovk
Redirect topics to topic/
930c77e
CAM-Gerlach
CAM-Gerlach reviewed Feb 2, 2023
View reviewed changes
Comment threadpep-0001.txt Outdated
Comment threadinfra/main.tf Outdated
@CAM-Gerlach

CAM-Gerlach commented Feb 2, 2023

Copy link
Copy Markdown
Member

Oh, and just to be sure, still missing:

It should also be added to the header listing under How to use this template in PEP 12, and maybe also as a short bullet point there.

@CAM-GerlachCAM-Gerlach mentioned this pull request Feb 2, 2023
Merged
hugovkand others added 4 commits February 2, 2023 12:51
@hugovk@CAM-Gerlach
Update topics->topic redirect
481761e
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@hugovk@CAM-Gerlach
Singular topic
c5a5811
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@hugovk
Add topic header to PEP 12
d75d4cd
@hugovk
Add htmlview target to Makefile
16f6d7a
@hugovk

hugovk commented Feb 2, 2023•
edited by pradyunsg
Loading

Copy link
Copy Markdown
MemberAuthor

Thanks, updated!

I also added an htmlview target to the Makefile, consistent with CPython docs and Devguide. Let me know if this should be in a separate PR. My fingers will be thankful, especially as the docs are output to three different directories: build, build/html, _build/html!

CAM-Gerlach
CAM-Gerlach approved these changes Feb 3, 2023
View reviewed changes

@CAM-GerlachCAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hugovk

warsaw
warsaw approved these changes Feb 3, 2023
View reviewed changes

@warsawwarsaw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with suggestion

Comment threadMakefile
@hugovk
hugovk merged commit e92c4d6 into python:mainFeb 3, 2023
@hugovk
hugovk deleted the meta-add-topic-to-peps-1-and-12 branch February 3, 2023 19:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsawwarsawwarsaw approved these changes
@pradyunsgpradyunsgpradyunsg approved these changes
@CAM-GerlachCAM-GerlachCAM-Gerlach approved these changes
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@ewdurbinewdurbinAwaiting requested review from ewdurbinewdurbin is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hugovk@CAM-Gerlach@warsaw@pradyunsg