Skip to content

Meta: Rename PR templates to be more descriptive in the GitHub UI - #2998

Merged
CAM-Gerlach merged 2 commits into
python:mainfrom
CAM-Gerlach:rm-pr-template-data-block
Feb 1, 2023
Merged

Meta: Rename PR templates to be more descriptive in the GitHub UI#2998
CAM-Gerlach merged 2 commits into
python:mainfrom
CAM-Gerlach:rm-pr-template-data-block

Conversation

@CAM-Gerlach

Copy link
Copy Markdown
Member

Followup to #2956 , as there was no way to test any of this before pushing it live to the production repo. This:

  • Remove the data block at the top of each template that apparently isn't currently used by the present GitHub implementation of the feature
  • Gives the templates more descriptive and human-readable names since it's the filenames that are displayed directly in the UI.
  • Is clearer about the purpose of the Other template (Infra/Meta), since GitHub also provides a blank option
  • Also trims an unnecessary title heading from most of the templates to slim them down further

Hopefully we can merge this quickly to avoid this issue lingering for anyone who submits a PR.

@CAM-GerlachCAM-Gerlach added infra Core infrastructure for building and rendering PEPs meta Related to the repo itself and its processes labels Feb 1, 2023
@CAM-Gerlach
CAM-Gerlach requested a review from a team as a code ownerFebruary 1, 2023 20:57
@CAM-GerlachCAM-Gerlach removed the infra Core infrastructure for building and rendering PEPs label Feb 1, 2023
@CAM-GerlachCAM-Gerlach self-assigned this Feb 1, 2023

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when ready 👍

@brettcannonbrettcannon changed the title Meta: Rename PR templates to be more descriptive in the GitHu UIMeta: Rename PR templates to be more descriptive in the GitHub UIFeb 1, 2023
@CAM-Gerlach
CAM-Gerlach merged commit 40f1df9 into python:mainFeb 1, 2023
@CAM-Gerlach
CAM-Gerlach deleted the rm-pr-template-data-block branch February 1, 2023 22:45
@CAM-Gerlach

Copy link
Copy Markdown
MemberAuthor

Looking better now, thanks:

image

Only one little tweak—the "Other" entry needs the "Other" to sort properly and not look out of place with the, erm, others. I opened #3000 to do that.

@CAM-Gerlach

Copy link
Copy Markdown
MemberAuthor

Err, #3001 now

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metaRelated to the repo itself and its processes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@CAM-Gerlach@hugovk