PEP 649: Improve description of semantics and mark as accepted by larryhastings · Pull Request #3138 · python/peps

larryhastings · 2023-05-05T11:16:24Z

Stipulate that name resolution for annotations under 649 must be identical to stock semantics.
Don't specify exactly the mechanism that conformant implementations must use to implement 649. Instead, do describe how CPython might do it, but leave the actual details of how to implement 649 up to each language implementation.
Incorporate Jelle's suggestion that the formats for inspect.get_annotations() be in an enum.IntEnum.

📚 Documentation preview 📚: https://pep-previews--3138.org.readthedocs.build/

* Stipulate that name resolution for annotations under 649 must be *identical* to stock semantics. * *Don't* specify exactly the mechanism that conformant implementations must use to implement 649. Instead, *do* describe how CPython might do it, but leave the actual details of how to implement 649 up to each language implementation. * Incorporate Jelle's suggestion that the formats for inspect.get_annotations() be in an enum.IntEnum.

JelleZijlstra · 2023-05-08T03:47:15Z

A minor suggestion brought over from #3127: maybe we should drop FORMAT_MIN and FORMAT_MAX? I don't see much use for them if there is an enum; if you really want these values you can do min(member.value for member in inspect.AnnotationFormat).

larryhastings · 2023-05-08T22:02:55Z

FWIW, I duplicated some work in this PR that was already in another PR, #3127. Having made the mistake, it seemed easiest to close the other PEP and do everything in this one PR. Sorry for the miasma.

larryhastings · 2023-05-08T22:09:55Z

A minor suggestion brought over from #3127: maybe we should drop FORMAT_MIN and FORMAT_MAX?

Done. Iterating over the enum is a better solution.

…ython#3122) - Lazy evaluation means that referencing a later type variable works at runtime - Disallow walrus in TypeVar bounds, and also disallow yield/yield from/await in the same contexts - Remove rejection of lambda lifting; that is the implementation we are using now - Change the AST - Change of direction on mangling - More precise scoping rules Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>

larryhastings · 2023-05-08T22:27:31Z

Huh? GitHub decided to request Guido and Thomas as reviewers. I didn't ask for that. I've removed Guido and Thomas from review requests--obviously, they're welcome to review the PR, but I don't think it's necessary. Sorry for the churn, folks.

JelleZijlstra · 2023-05-08T22:49:32Z

Huh? GitHub decided to request Guido and Thomas as reviewers. I didn't ask for that. I've removed Guido and Thomas from review requests--obviously, they're welcome to review the PR, but I don't think it's necessary. Sorry for the churn, folks.

I think you incorrectly merged in the two most recent commits on the main branch (which happen to be on 693 and 695). I'm going to click the "Update branch" button to get those commits out of the PR branch.

larryhastings · 2023-05-09T01:15:00Z

Thanks, Jelle. Thank goodness Git is so conceptually simple and easy to use!

larryhastings · 2023-05-09T09:08:34Z

@AA-Turner, on the other thread you said "does this list need updating?" with regards to the format IntEnums, and I didn't know what you meant. I just now noticed: in one section, the FORWARDREF enum is 2, and in another section it's 3. Is that what you were referring to?

(And, of course, I'm fixing that now. Time to pick the final values!)

AA-Turner · 2023-05-09T13:53:07Z

@AA-Turner, on the other thread you said "does this list need updating?" with regards to the format IntEnums, and I didn't know what you meant.

I was referring to the repr for VALUE &c -- you'd updated the list starting on line 576 to read inspect.AnnotationFormat.VALUE, but the list starting on line 78 still read inspect.VALUE. This PR consistently uses inspect.VALUE et al., so I think the comment is moot. Thanks for following up!

A

carljm

Left some additional comments, but I don't feel super strongly about any of them; generally this looks good to me!

larryhastings · 2023-05-10T01:46:34Z

Somehow I'm unable to reply directly to Carl's most recent comment. He said:

We don't have to explicitly document support for everything that is technically possible. Are there strong use cases for someone using these public inspection methods to not use the enum values?

There are not, and I expect everyone to use the enum values. I was just trying to be precise.

But, we already defined the allowable values for __annotate__; why are we defining it twice? How about we simplify the text as follows:

The format parameter on these two functions accept the same values
as the format parameter on the __annotate__ magic method
defined above; however, these format parameters also have a default
value of inspect.VALUE.

larryhastings · 2023-05-10T01:53:40Z

Fingers crossed that we can ship 72b8183. I believe I've addressed everybody's comments (and basically incorporated everyone's suggestions).

larryhastings · 2023-05-10T01:59:34Z

In the words of the rare "Big Bang Bar" pinball machine:

Wow! That didn't last long.

JelleZijlstra

All the changes look good to me, thanks!

Technically, changes to accepted PEPs need SC approval. I doubt the SC would have a big problem with anything in this PR, but ideally you'll have to get their signoff. Who knows, maybe they'll insist that we really need that __locals__ attribute on functions.

larryhastings · 2023-05-10T02:09:08Z

Good call. I'll ping them once we're collectively happy with these changes. I bet we'll get a quick rubber stamp, and then I'll merge.

carljm

Changes look good to me!

CAM-Gerlach

Standard reminder: You can directly apply all the suggestions you want in one go by going to Files changed -> Clicking Add to batch on each suggestion -> When done, clicking Commit

It should be noted that with this PR, the PEP is marked as accepted—I've updated the title accordingly to note this key fact.

Accepted PEP checklist:

SC/PEP Delegate has formally accepted/rejected the PEP and posted to the Discussions-To thread
Pull request title in appropriate format (PEP 123: Mark as Accepted)
Status changed to Accepted/Rejected
Resolution link points directly to SC/PEP Delegate official acceptance/rejected post
~~Acceptance/rejection notice added, if the SC/PEP delegate had major conditions or comments~~ N/A besides updating the Python-Version
Discussions-To, Post-History and Python-Version up to date [Done in suggestions]

larryhastings · 2023-05-15T23:01:08Z

The SC is happy with the changes.

python/steering-council#187

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>

Co-authored-by: Emily Morehouse <emilyemorehouse@gmail.com>

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>

larryhastings requested review from JelleZijlstra and carljm May 5, 2023 11:16

hugovk reviewed May 5, 2023
View reviewed changes

Comment threadpep-0649.rst Outdated

AA-Turner changed the title ~~Improve PEP 649's description of its semantics.~~PEP 649: Improve description of semanticsMay 5, 2023

Fix lint.
23148f6

JelleZijlstra reviewed May 5, 2023
View reviewed changes

Comment threadpep-0649.rst Outdated

carljm reviewed May 5, 2023
View reviewed changes

Comment threadpep-0649.rst Outdated

AA-Turner mentioned this pull request May 5, 2023
PEP 649: Change the defined format values to an IntEnum #3127
Closed

AA-Turner reviewed May 5, 2023
View reviewed changes

Comment threadpep-0649.rst Outdated
Comment threadpep-0649.rst Outdated

hugovkand others added 3 commits May 8, 2023 15:24

PEP 693: Postpone 3.12.0b1 by two weeks (python#3139)
9ace095

Incorporate changes from feedback, mark Accepted.
8989c52

larryhastings requested review from Yhg1s and gvanrossum as code owners May 8, 2023 22:24

larryhastings removed request for Yhg1s and gvanrossum May 8, 2023 22:26

larryhastings added 2 commits May 8, 2023 15:32

Fix PEP 12 header *order compliance*. Wow.
af3aa36

Fix Sphinx complaints.
7af54df

Merge branch 'main' into nail_down_annotation_expression_semantics
0034059

Make enum consistent, flesh out observed semantics.
3d34d84

hugovk reviewed May 9, 2023
View reviewed changes

Comment threadpep-0649.rst Outdated

Add "Resolution" header, as pointed out by Hugo.
06d53a4

Switch to other URL for Resolution header.
1a316cc

carljm approved these changes May 9, 2023
View reviewed changes

Comment threadpep-0649.rst Outdated
Comment threadpep-0649.rst Outdated
Comment threadpep-0649.rst Outdated
Comment threadpep-0649.rst
Comment threadpep-0649.rst Outdated

Apply global_enum to inspect.AnnotationFormat
08485e9

Final? text / semantics cleanup pass.
72b8183

JelleZijlstra reviewed May 10, 2023
View reviewed changes

Comment threadpep-0649.rst Outdated

"accept" -> "accepts". Bettering my Englishes.
ade4a90

JelleZijlstra approved these changes May 10, 2023
View reviewed changes

carljm approved these changes May 10, 2023
View reviewed changes

Add new "post history" reflecting the updates.
0503ca1

larryhastings mentioned this pull request May 10, 2023
PEP 649 update python/steering-council#187
Closed

CAM-Gerlach changed the title ~~PEP 649: Improve description of semantics~~PEP 649: Improve description of semantics and mark as acceptedMay 10, 2023

AA-Turner approved these changes May 10, 2023
View reviewed changes

CAM-Gerlach reviewed May 10, 2023
View reviewed changes

Comment threadpep-0649.rst
Comment threadpep-0649.rst Outdated

CAM-Gerlach added the DO-NOT-MERGE label May 10, 2023

CAM-Gerlach reviewed May 10, 2023
View reviewed changes

Comment threadpep-0649.rst

emilyemorehouse reviewed May 15, 2023
View reviewed changes

Comment threadpep-0649.rst Outdated

larryhastingsand others added 3 commits May 15, 2023 16:02

Update post history with all conversations, courtesy CAM!
7da747a
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>

Fix typo. Thanks, Emily!
c9b0773
Co-authored-by: Emily Morehouse <emilyemorehouse@gmail.com>

Add "Discussions-To" header. Thanks, CAM!
c36b491
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>

larryhastings removed the DO-NOT-MERGE label May 15, 2023

Attempt to satisfy "validate-post-history" hook.
7896e98

larryhastings merged commit a111ec4 into python:mainMay 16, 2023

larryhastings deleted the nail_down_annotation_expression_semantics branch May 16, 2023 04:08

Uh oh!

Uh oh!

Conversation

larryhastings commented May 5, 2023• edited by github-actions BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JelleZijlstra commented May 8, 2023

Uh oh!

larryhastings commented May 8, 2023

Uh oh!

larryhastings commented May 8, 2023

Uh oh!

larryhastings commented May 8, 2023

Uh oh!

JelleZijlstra commented May 8, 2023

Uh oh!

larryhastings commented May 9, 2023

Uh oh!

larryhastings commented May 9, 2023

Uh oh!

Uh oh!

AA-Turner commented May 9, 2023

Uh oh!

carljm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

larryhastings commented May 10, 2023

Uh oh!

Uh oh!

larryhastings commented May 10, 2023

Uh oh!

larryhastings commented May 10, 2023

Uh oh!

JelleZijlstra left a comment

Choose a reason for hiding this comment

Uh oh!

larryhastings commented May 10, 2023

Uh oh!

carljm left a comment

Choose a reason for hiding this comment

Uh oh!

CAM-Gerlach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

larryhastings commented May 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

larryhastings commented May 5, 2023•
edited by github-actions Bot
Loading