Uh oh!
There was an error while loading. Please reload this page.
Infra: Check Sphinx warnings on CI - #3213
Closed
hugovk wants to merge 7 commits into
Closed
Conversation
hugovk
commented
Jul 27, 2023
MemberAuthor
It found one! #3189 was merged since I branched :) |
AA-Turner
commented
Jul 27, 2023
Member
See #3214 to resolve several warnings. |
Uh oh!
There was an error while loading. Please reload this page.
Member
The only outstanding warnings are now unreferenced footnotes, of which we have 59 across 40 files: Full listA |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner
commented
Jul 31, 2023
Member
I've opened a first batch of 10 PRs to resolve PEPs 232 through 340. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to what we have in the CPython repo, most recently: python/cpython#106460, and will help us gradually remove Sphinx warnings, and avoid new ones being introduces.
It checks three things:
If a file previously had no warnings (not listed in
.nitignore), and new ones are introduced, it failsIf a file previously had warnings (it's lsited in
.nitignore), but now has none, it fails and tells us to remove it from.nitignoreIf a file previously had warnings (it's listed in
.nitignore), and still has warnings, it doesn't fail, but it will annotate the PR to show the warningI've intentionally kept the code and layout as close as possible to the CPython version (see https://github.com/python/cpython/tree/main/Doc/tools) for easier future maintenance.
📚 Documentation preview 📚: https://pep-previews--3213.org.readthedocs.build/