Skip to content

PEP 726: Module __setattr__ and __delattr__ - #3301

Merged
AA-Turner merged 11 commits into
python:mainfrom
skirpichev:setdelattr
Aug 31, 2023
Merged

PEP 726: Module __setattr__ and __delattr__#3301
AA-Turner merged 11 commits into
python:mainfrom
skirpichev:setdelattr

Conversation

@skirpichev

@skirpichevskirpichev commented Aug 24, 2023

Copy link
Copy Markdown
Member

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval (gh-106016: Support customizing of module attributes access with __setattr__/__delattr__ (PEP 726) cpython#108261 (comment))
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements


📚 Documentation preview 📚: https://pep-previews--3301.org.readthedocs.build/

@skirpichev
skirpichev requested a review from a team as a code ownerAugust 24, 2023 04:14
Comment threadpep-0726.rst Outdated
Comment threadpep-0726.rst Outdated
@AA-Turner
AA-Turner self-requested a review August 24, 2023 04:26
@AA-Turner

Copy link
Copy Markdown
Member

@skirpichev please include a brief "How to Teach This" section and also please update the copyright declaration to the standard form:

This document is placed in the public domain or under the
CC0-1.0-Universal license, whichever is more permissive.

A

Comment threadpep-0726.rst Outdated

@AA-TurnerAA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright editorially, thank you!

A

@AA-Turner

AA-Turner commented Aug 31, 2023

Copy link
Copy Markdown
Member

Please open a new "PEP 726" discussion topic on Discourse and update Discussions-To and Post-History with it, then this PEP can be merged.

A

Comment threadpep-0726.rst Outdated
Comment threadpep-0726.rst Outdated
@AA-Turner
AA-Turner enabled auto-merge (squash) August 31, 2023 03:40
@AA-Turner
AA-Turner merged commit 43a28ef into python:mainAug 31, 2023
@skirpichev
skirpichev deleted the setdelattr branch August 31, 2023 03:42
@AA-Turner

Copy link
Copy Markdown
Member

Thanks @skirpichev -- now to see what thoughts are on the PEP!

A

@skirpichev

Copy link
Copy Markdown
MemberAuthor

Thanks for review.

@brianschubertbrianschubert added the new-pep A new draft PEP submitted for initial review label Jun 13, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-pepA new draft PEP submitted for initial review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skirpichev@AA-Turner@Rosuav@brianschubert