Uh oh!
There was an error while loading. Please reload this page.
All PEPs: Move to peps/ folder - #3418
Conversation
hugovk
left a comment
There was a problem hiding this comment.
First up, some extra pre-commit cleanup.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
AA-Turner
commented
Sep 3, 2023
I reviewed the pre-commit guidance---it seems that our usages of A |
- Group ignores by purpose - Remove 'package' - Remove 'pep-????.html' - Allow topic to cover top level or in peps/
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
AA-Turner
commented
Sep 4, 2023
Out of a slight fear of this going the same way as #2672, please may I ask if anyone has any burning passions against the general proposal to move the PEPs into a sub-folder? (We can tweak implementation details later, of course.) If all is well, I'd like to set a timeline for merging this -- perhaps Tuesday or Wednesday, if that's not too early? A |
Rosuav
commented
Sep 4, 2023
No burning passions, no. Just a broad "is this worth the effort", but I'm not going to stand in anyone's way. |
# Conflicts: # .pre-commit-config.yaml # pep_sphinx_extensions/tests/conftest.py
AA-Turner
commented
Sep 9, 2023
I'll merge this today, sorry in advance for the review-request spam. A |
AA-Turner
commented
Sep 9, 2023
I'll keep an eye on https://peps.python.org just in case. |
AA-Turner
commented
Sep 9, 2023
All seems well! A |
terryjreedy
commented
May 3, 2025
@Jose1654 'approving' merged pull requests spams a large number of people and is otherwise useless. Please do not repeat. |
Rosuav
commented
May 4, 2025
I already reported the user to GitHub for spamming. Are we able to disallow reviews from non-members? This keeps happening, every once in a while. |
hugovk
commented
May 4, 2025
We can disallow reviews that approve/request changes for those without explicit read access, but not cannot disallow comment reviews. Do we get useful approve/request-change reviews from real non-members? We often have external co-authors. They can add a comment instead, but is that ok? |
JelleZijlstra
commented
May 4, 2025
I would oppose changing this configuration because of the occasional random user doing something annoying. Just ignore them. Users outside the Python org can and do leave useful reviews, especially on this repo. |
Rosuav
commented
May 4, 2025
Yeah, that's fair. It'd be nice to be able to disallow drive-bys from people who have had no other interaction AND who don't leave any comments in the review, but that's a bit too sophisticated to ask for. |
Would resolve#10.
cc: @python/pep-editors for views.
I've structured as distinct commits -- the first does the actual move, the following thirteen tackle follow-ups and previous assumptions over file locations.
A
📚 Documentation preview 📚: https://pep-previews--3418.org.readthedocs.build/