Skip to content

PEP 612: Mark as Final - #3575

Merged
hugovk merged 6 commits into
python:mainfrom
hugovk:pep612-mark-as-final
Jan 12, 2024
Merged

PEP 612: Mark as Final#3575
hugovk merged 6 commits into
python:mainfrom
hugovk:pep612-mark-as-final

Conversation

@hugovk

@hugovkhugovk commented Dec 10, 2023•
edited
Loading

Copy link
Copy Markdown
Member
  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive (or canonical-pypa-spec, for packaging PEPs)

Helps #2872 and #3579.

Link to https://docs.python.org/3/library/typing.html#typing.ParamSpec as the canonical docs, and remove a redundant header.

cc @Fidget-Spinner

📚 Documentation preview 📚: https://pep-previews--3575.org.readthedocs.build/pep-0612/

Fidget-Spinner
Fidget-Spinner approved these changes Dec 10, 2023
View reviewed changes

@Fidget-SpinnerFidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation is done. Jelle and I implemented it https://docs.python.org/3/whatsnew/3.10.html#pep-612-parameter-specification-variables.

Fidget-Spinner
Fidget-Spinner requested changes Dec 10, 2023
View reviewed changes

@Fidget-SpinnerFidget-Spinner left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment

Comment threadpeps/pep-0612.rst Outdated
@hugovkhugovk mentioned this pull request Dec 10, 2023
Merged
6 tasks
JelleZijlstra
JelleZijlstra reviewed Jan 9, 2024
View reviewed changes
Comment threadpeps/pep-0612.rst Outdated
@hugovkhugovk mentioned this pull request Jan 9, 2024
Merged
hugovk
hugovk commented Jan 9, 2024
View reviewed changes
Comment threadpeps/pep-0612.rst
Comment threadpep_sphinx_extensions/pep_processor/parsing/pep_banner_directive.py
@brettcannon
brettcannon removed their request for review January 11, 2024 19:03
JelleZijlstra
JelleZijlstra approved these changes Jan 12, 2024
View reviewed changes

@JelleZijlstraJelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk
hugovk merged commit f7f9f2d into python:mainJan 12, 2024
@hugovk
hugovk deleted the pep612-mark-as-final branch January 15, 2024 17:20
@hugovkhugovk mentioned this pull request Jan 15, 2024
Closed
16 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes
@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes
@gvanrossumgvanrossumAwaiting requested review from gvanrossumgvanrossum is a code owner
@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk@JelleZijlstra@Fidget-Spinner