Skip to content

Meta: Allow adding date to Resolution header - #4061

Merged
JelleZijlstra merged 6 commits into
python:mainfrom
JelleZijlstra:resolutiondate
Oct 16, 2024
Merged

Meta: Allow adding date to Resolution header#4061
JelleZijlstra merged 6 commits into
python:mainfrom
JelleZijlstra:resolutiondate

Conversation

@JelleZijlstra

@JelleZijlstraJelleZijlstra commented Oct 16, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Fixes#4054.

📚 Documentation preview 📚: https://pep-previews--4061.org.readthedocs.build/

hugovk
hugovk reviewed Oct 16, 2024
View reviewed changes
Comment thread.pre-commit-config.yaml
Comment threadcheck-peps.py Outdated
warsaw
warsaw approved these changes Oct 16, 2024
View reviewed changes

@warsawwarsaw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, but I also wonder whether it's obvious that the date link is pointing to the DPO thread in the examples. Maybe it's good enough, but I also kind of liked the "Discord thread" text! Just a thought, no objections from me.

hugovk
hugovk approved these changes Oct 16, 2024
View reviewed changes

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I added some extra tests in hugovk@6bc1e72 in case you want to pull it in. Or I can PR it your branch, or after this is merged?

@JelleZijlstra

JelleZijlstra commented Oct 16, 2024

Copy link
Copy Markdown
MemberAuthor

Thanks Hugo! Feel free to push those tests onto my branch; if not I can run the right git commands in a little bit.

@hugovk

hugovk commented Oct 16, 2024

Copy link
Copy Markdown
Member

Pushed!

@JelleZijlstraJelleZijlstra mentioned this pull request Oct 16, 2024
Closed
@JelleZijlstra
JelleZijlstra merged commit c56c5c5 into python:mainOct 16, 2024
@JelleZijlstra
JelleZijlstra deleted the resolutiondate branch October 16, 2024 16:05
@JelleZijlstraJelleZijlstra mentioned this pull request Oct 16, 2024
Closed
4 tasks
@gaborbernat

gaborbernat commented Oct 16, 2024

Copy link
Copy Markdown
Contributor

Thanks folks, great improvement ❤️

gvanrossum pushed a commit to gvanrossum/peps that referenced this pull request Dec 10, 2024
@JelleZijlstra@hugovk@gvanrossum
Meta: Allow adding date to Resolution header (python#4061)
5ec90aa
Fixespython#4054
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsawwarsawwarsaw approved these changes
@hugovkhugovkhugovk approved these changes
@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner
@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner
@CAM-GerlachCAM-GerlachAwaiting requested review from CAM-GerlachCAM-Gerlach is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow adding a date to the Resolution of a PEP

4 participants

@JelleZijlstra@hugovk@gaborbernat@warsaw