Uh oh!
There was an error while loading. Please reload this page.
Allow installing runtimes from a script shebang. - #236
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to install Python runtimes based on the shebang line found in a script file. This addresses issue #235 by allowing the install command to read a script's shebang (e.g., #! python1.1.exe) and automatically install the corresponding runtime if it's not already present.
Key changes:
- Modified install_command.py to extract runtime specifications from script shebangs when the
--from-scriptflag is used - Replaced global
DOWNLOAD_CACHEwith a per-command cache stored incmd.scratchfor better testability - Added test infrastructure and test cases to verify the new functionality
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/manage/install_command.py | Added logic to parse shebang from scripts and extract runtime tags; replaced global DOWNLOAD_CACHE with cmd.scratch-based caching |
| tests/test_install_command.py | Added InstallCommandTestCmd helper class and test cases for script-based installation |
| tests/conftest.py | Modified assert_log to perform type conversion when comparing logged values with expected values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Fixes#235