Skip to content

Avoid crashing when invalid __install__.json file exists.#299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 8 commits into from
Mar 31, 2026
Merged

Avoid crashing when invalid __install__.json file exists. #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
55390c5
Avoid crashing when invalid __install__.json file exists.
zooba Mar 31, 2026
c7d5b43
Improve purge to clean up unrecognised directories
zooba Mar 31, 2026
a9d2ce4
Set install_dir on test config
zooba Mar 31, 2026
2b50aaf
Use iterdir not listdir
zooba Mar 31, 2026
c99a712
Add purge to test run
zooba Mar 31, 2026
e7370ce
Simplify and use helpers
zooba Mar 31, 2026
819e54a
Allow path to be deleted in test
zooba Mar 31, 2026
d8dcd94
Don't purge everything anymore
zooba Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -182,6 +182,20 @@ jobs:
PYMANAGER_DEBUG: true
shell: powershell

- name: 'Test purge'
run: |
$env:PYTHON_MANAGER_CONFIG = (gi $env:PYTHON_MANAGER_CONFIG).FullName
pymanager uninstall --purge -y
if (Test-Path test_installs) {
dir -r test_installs
} else {
Write-Host "test_installs directory has been deleted"
}
env:
PYTHON_MANAGER_INCLUDE_UNMANAGED: false
PYTHON_MANAGER_CONFIG: .\test-config.json
PYMANAGER_DEBUG: true

- name: 'Offline bundle download and install'
run: |
pymanager list --online 3 3-32 3-64 3-arm64
Expand Down
15 changes: 15 additions & 0 deletions ci/release.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -323,6 +323,21 @@ stages:
PYTHON_MANAGER_CONFIG: .\test-config.json
PYMANAGER_DEBUG: true

- powershell: |
$env:PYTHON_MANAGER_CONFIG = (gi $env:PYTHON_MANAGER_CONFIG).FullName
pymanager uninstall --purge -y
if (Test-Path test_installs) {
dir -r test_installs
} else {
Write-Host "test_installs directory has been deleted"
}
displayName: 'Test purge'
timeoutInMinutes: 5
env:
PYTHON_MANAGER_INCLUDE_UNMANAGED: false
PYTHON_MANAGER_CONFIG: .\test-config.json
PYMANAGER_DEBUG: true

- powershell: |
pymanager list --online 3 3-32 3-64 3-arm64
pymanager install --download .\bundle 3 3-32 3-64 3-arm64
Expand Down
8 changes: 8 additions & 0 deletions src/manage/installs.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,14 @@ def _get_installs(install_dir):
try:
with p.open() as f:
j = json.load(f)
except ValueError:
LOGGER.warn(
"Failed to read install at %s. You may have a broken "
"install, which can be cleaned up by deleting the directory.",
d
)
LOGGER.debug("ERROR", exc_info=True)
continue
except FileNotFoundError:
continue

Expand Down
4 changes: 1 addition & 3 deletions src/manage/uninstall_command.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -66,9 +66,7 @@ def _do_purge_global_dir(global_dir, warn_msg, *, hive=None, subkey="Environment
if not global_dir.is_dir():
return
LOGGER.info("Purging global commands from %s", global_dir)
for f in _iterdir(global_dir):
LOGGER.debug("Purging %s", f)
rmtree(f, after_5s_warning=warn_msg)
rmtree(global_dir, after_5s_warning=warn_msg)


def execute(cmd):
Expand Down
12 changes: 6 additions & 6 deletions tests/conftest.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -152,11 +152,11 @@ def localserver():


class FakeConfig:
def __init__(self, global_dir, installs=[]):
self.global_dir = global_dir
self.root = global_dir.parent if global_dir else None
self.download_dir = self.root / "_cache" if self.root else None
self.start_folder = self.root / "_start" if self.root else None
def __init__(self, root, installs=[]):
self.root = self.install_dir = root
self.global_dir = root / "bin" if root else None
self.download_dir = root / "_cache" if root else None
self.start_folder = root / "_start" if root else None
self.pep514_root = REG_TEST_ROOT
self.confirm = False
self.installs = list(installs)
Expand DownExpand Up@@ -186,7 +186,7 @@ def ask_yn(self, question):

@pytest.fixture
def fake_config(tmp_path):
return FakeConfig(tmp_path / "bin")
return FakeConfig(tmp_path)


class RegistryFixture:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_uninstall_command.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ def test_purge_global_dir(monkeypatch, registry, tmp_path):
UC._do_purge_global_dir(tmp_path, "SLOW WARNING", hive=registry.hive, subkey=registry.root)
assert registry.getvalueandkind("", "Path") == (
rf"C:\A;{tmp_path}\X;C:\B;%PTH%;C:\%D%\E", winreg.REG_SZ)
assert not list(tmp_path.iterdir())
assert not tmp_path.is_dir() or not list(tmp_path.iterdir())


def test_null_purge(fake_config):
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Avoid crashing when invalid __install__.json file exists. by zooba · Pull Request #299 · python/pymanager · GitHub
Skip to content
Avoid crashing when invalid __install__.json file exists.#299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

zooba
merged 8 commits into

from

Mar 31, 2026
 Merged


Avoid crashing when invalid __install__.json file exists.
#299
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


8 commits


Select commit
Hold shift + click to select a range
55390c5

Avoid crashing when invalid __install__.json file exists.


zooba Mar 31, 2026
c7d5b43

Improve purge to clean up unrecognised directories


zooba Mar 31, 2026
a9d2ce4

Set install_dir on test config


zooba Mar 31, 2026
2b50aaf

Use iterdir not listdir


zooba Mar 31, 2026
c99a712

Add purge to test run


zooba Mar 31, 2026
e7370ce

Simplify and use helpers


zooba Mar 31, 2026
819e54a

Allow path to be deleted in test


zooba Mar 31, 2026
d8dcd94

Don't purge everything anymore


zooba Mar 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 14 additions & 0 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -182,6 +182,20 @@ jobs:
 PYMANAGER_DEBUG: true
 shell: powershell

 - name: 'Test purge'
 run: |
 $env:PYTHON_MANAGER_CONFIG = (gi $env:PYTHON_MANAGER_CONFIG).FullName
 pymanager uninstall --purge -y
 if (Test-Path test_installs) {
 dir -r test_installs
 } else {
 Write-Host "test_installs directory has been deleted"
 }
 env:
 PYTHON_MANAGER_INCLUDE_UNMANAGED: false
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - name: 'Offline bundle download and install'
 run: |
 pymanager list --online 3 3-32 3-64 3-arm64
Expand Down

15 changes: 15 additions & 0 deletions
ci/release.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -323,6 +323,21 @@ stages:
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - powershell: |
 $env:PYTHON_MANAGER_CONFIG = (gi $env:PYTHON_MANAGER_CONFIG).FullName
 pymanager uninstall --purge -y
 if (Test-Path test_installs) {
 dir -r test_installs
 } else {
 Write-Host "test_installs directory has been deleted"
 }
 displayName: 'Test purge'
 timeoutInMinutes: 5
 env:
 PYTHON_MANAGER_INCLUDE_UNMANAGED: false
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - powershell: |
 pymanager list --online 3 3-32 3-64 3-arm64
 pymanager install --download .\bundle 3 3-32 3-64 3-arm64
Expand Down

8 changes: 8 additions & 0 deletions
src/manage/installs.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,14 @@ def _get_installs(install_dir):
 try:
 with p.open() as f:
 j = json.load(f)
 except ValueError:
 LOGGER.warn(
 "Failed to read install at %s. You may have a broken "
 "install, which can be cleaned up by deleting the directory.",
 d
 )
 LOGGER.debug("ERROR", exc_info=True)
 continue
 except FileNotFoundError:
 continue

Expand Down

4 changes: 1 addition & 3 deletions
src/manage/uninstall_command.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,9 +66,7 @@ def _do_purge_global_dir(global_dir, warn_msg, *, hive=None, subkey="Environment
 if not global_dir.is_dir():
 return
 LOGGER.info("Purging global commands from %s", global_dir)
 for f in _iterdir(global_dir):
 LOGGER.debug("Purging %s", f)
 rmtree(f, after_5s_warning=warn_msg)
 rmtree(global_dir, after_5s_warning=warn_msg)


def execute(cmd):
Expand Down

12 changes: 6 additions & 6 deletions
tests/conftest.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -152,11 +152,11 @@ def localserver():


class FakeConfig:
 def __init__(self, global_dir, installs=[]):
 self.global_dir = global_dir
 self.root = global_dir.parent if global_dir else None
 self.download_dir = self.root / "_cache" if self.root else None
 self.start_folder = self.root / "_start" if self.root else None
 def __init__(self, root, installs=[]):
 self.root = self.install_dir = root
 self.global_dir = root / "bin" if root else None
 self.download_dir = root / "_cache" if root else None
 self.start_folder = root / "_start" if root else None
 self.pep514_root = REG_TEST_ROOT
 self.confirm = False
 self.installs = list(installs)
Expand DownExpand Up@@ -186,7 +186,7 @@ def ask_yn(self, question):

@pytest.fixture
def fake_config(tmp_path):
 return FakeConfig(tmp_path / "bin")
 return FakeConfig(tmp_path)


class RegistryFixture:
Expand Down

2 changes: 1 addition & 1 deletion
tests/test_uninstall_command.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ def test_purge_global_dir(monkeypatch, registry, tmp_path):
 UC._do_purge_global_dir(tmp_path, "SLOW WARNING", hive=registry.hive, subkey=registry.root)
 assert registry.getvalueandkind("", "Path") == (
 rf"C:\A;{tmp_path}\X;C:\B;%PTH%;C:\%D%\E", winreg.REG_SZ)
 assert not list(tmp_path.iterdir())
 assert not tmp_path.is_dir() or not list(tmp_path.iterdir())


def test_null_purge(fake_config):
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Avoid crashing when invalid __install__.json file exists. by zooba · Pull Request #299 · python/pymanager · GitHub
Skip to content
Avoid crashing when invalid __install__.json file exists.#299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

zooba
merged 8 commits into

from

Mar 31, 2026
 Merged


Avoid crashing when invalid __install__.json file exists.
#299
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


8 commits


Select commit
Hold shift + click to select a range
55390c5

Avoid crashing when invalid __install__.json file exists.


zooba Mar 31, 2026
c7d5b43

Improve purge to clean up unrecognised directories


zooba Mar 31, 2026
a9d2ce4

Set install_dir on test config


zooba Mar 31, 2026
2b50aaf

Use iterdir not listdir


zooba Mar 31, 2026
c99a712

Add purge to test run


zooba Mar 31, 2026
e7370ce

Simplify and use helpers


zooba Mar 31, 2026
819e54a

Allow path to be deleted in test


zooba Mar 31, 2026
d8dcd94

Don't purge everything anymore


zooba Mar 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 14 additions & 0 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -182,6 +182,20 @@ jobs:
 PYMANAGER_DEBUG: true
 shell: powershell

 - name: 'Test purge'
 run: |
 $env:PYTHON_MANAGER_CONFIG = (gi $env:PYTHON_MANAGER_CONFIG).FullName
 pymanager uninstall --purge -y
 if (Test-Path test_installs) {
 dir -r test_installs
 } else {
 Write-Host "test_installs directory has been deleted"
 }
 env:
 PYTHON_MANAGER_INCLUDE_UNMANAGED: false
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - name: 'Offline bundle download and install'
 run: |
 pymanager list --online 3 3-32 3-64 3-arm64
Expand Down

15 changes: 15 additions & 0 deletions
ci/release.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -323,6 +323,21 @@ stages:
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - powershell: |
 $env:PYTHON_MANAGER_CONFIG = (gi $env:PYTHON_MANAGER_CONFIG).FullName
 pymanager uninstall --purge -y
 if (Test-Path test_installs) {
 dir -r test_installs
 } else {
 Write-Host "test_installs directory has been deleted"
 }
 displayName: 'Test purge'
 timeoutInMinutes: 5
 env:
 PYTHON_MANAGER_INCLUDE_UNMANAGED: false
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - powershell: |
 pymanager list --online 3 3-32 3-64 3-arm64
 pymanager install --download .\bundle 3 3-32 3-64 3-arm64
Expand Down

8 changes: 8 additions & 0 deletions
src/manage/installs.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,14 @@ def _get_installs(install_dir):
 try:
 with p.open() as f:
 j = json.load(f)
 except ValueError:
 LOGGER.warn(
 "Failed to read install at %s. You may have a broken "
 "install, which can be cleaned up by deleting the directory.",
 d
 )
 LOGGER.debug("ERROR", exc_info=True)
 continue
 except FileNotFoundError:
 continue

Expand Down

4 changes: 1 addition & 3 deletions
src/manage/uninstall_command.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,9 +66,7 @@ def _do_purge_global_dir(global_dir, warn_msg, *, hive=None, subkey="Environment
 if not global_dir.is_dir():
 return
 LOGGER.info("Purging global commands from %s", global_dir)
 for f in _iterdir(global_dir):
 LOGGER.debug("Purging %s", f)
 rmtree(f, after_5s_warning=warn_msg)
 rmtree(global_dir, after_5s_warning=warn_msg)


def execute(cmd):
Expand Down

12 changes: 6 additions & 6 deletions
tests/conftest.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -152,11 +152,11 @@ def localserver():


class FakeConfig:
 def __init__(self, global_dir, installs=[]):
 self.global_dir = global_dir
 self.root = global_dir.parent if global_dir else None
 self.download_dir = self.root / "_cache" if self.root else None
 self.start_folder = self.root / "_start" if self.root else None
 def __init__(self, root, installs=[]):
 self.root = self.install_dir = root
 self.global_dir = root / "bin" if root else None
 self.download_dir = root / "_cache" if root else None
 self.start_folder = root / "_start" if root else None
 self.pep514_root = REG_TEST_ROOT
 self.confirm = False
 self.installs = list(installs)
Expand DownExpand Up@@ -186,7 +186,7 @@ def ask_yn(self, question):

@pytest.fixture
def fake_config(tmp_path):
 return FakeConfig(tmp_path / "bin")
 return FakeConfig(tmp_path)


class RegistryFixture:
Expand Down

2 changes: 1 addition & 1 deletion
tests/test_uninstall_command.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ def test_purge_global_dir(monkeypatch, registry, tmp_path):
 UC._do_purge_global_dir(tmp_path, "SLOW WARNING", hive=registry.hive, subkey=registry.root)
 assert registry.getvalueandkind("", "Path") == (
 rf"C:\A;{tmp_path}\X;C:\B;%PTH%;C:\%D%\E", winreg.REG_SZ)
 assert not list(tmp_path.iterdir())
 assert not tmp_path.is_dir() or not list(tmp_path.iterdir())


def test_null_purge(fake_config):
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Avoid crashing when invalid __install__.json file exists. by zooba · Pull Request #299 · python/pymanager · GitHub
Skip to content
Avoid crashing when invalid __install__.json file exists.#299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

zooba
merged 8 commits into

from

Mar 31, 2026
 Merged


Avoid crashing when invalid __install__.json file exists.
#299
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


8 commits


Select commit
Hold shift + click to select a range
55390c5

Avoid crashing when invalid __install__.json file exists.


zooba Mar 31, 2026
c7d5b43

Improve purge to clean up unrecognised directories


zooba Mar 31, 2026
a9d2ce4

Set install_dir on test config


zooba Mar 31, 2026
2b50aaf

Use iterdir not listdir


zooba Mar 31, 2026
c99a712

Add purge to test run


zooba Mar 31, 2026
e7370ce

Simplify and use helpers


zooba Mar 31, 2026
819e54a

Allow path to be deleted in test


zooba Mar 31, 2026
d8dcd94

Don't purge everything anymore


zooba Mar 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 14 additions & 0 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -182,6 +182,20 @@ jobs:
 PYMANAGER_DEBUG: true
 shell: powershell

 - name: 'Test purge'
 run: |
 $env:PYTHON_MANAGER_CONFIG = (gi $env:PYTHON_MANAGER_CONFIG).FullName
 pymanager uninstall --purge -y
 if (Test-Path test_installs) {
 dir -r test_installs
 } else {
 Write-Host "test_installs directory has been deleted"
 }
 env:
 PYTHON_MANAGER_INCLUDE_UNMANAGED: false
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - name: 'Offline bundle download and install'
 run: |
 pymanager list --online 3 3-32 3-64 3-arm64
Expand Down

15 changes: 15 additions & 0 deletions
ci/release.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -323,6 +323,21 @@ stages:
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - powershell: |
 $env:PYTHON_MANAGER_CONFIG = (gi $env:PYTHON_MANAGER_CONFIG).FullName
 pymanager uninstall --purge -y
 if (Test-Path test_installs) {
 dir -r test_installs
 } else {
 Write-Host "test_installs directory has been deleted"
 }
 displayName: 'Test purge'
 timeoutInMinutes: 5
 env:
 PYTHON_MANAGER_INCLUDE_UNMANAGED: false
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - powershell: |
 pymanager list --online 3 3-32 3-64 3-arm64
 pymanager install --download .\bundle 3 3-32 3-64 3-arm64
Expand Down

8 changes: 8 additions & 0 deletions
src/manage/installs.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,14 @@ def _get_installs(install_dir):
 try:
 with p.open() as f:
 j = json.load(f)
 except ValueError:
 LOGGER.warn(
 "Failed to read install at %s. You may have a broken "
 "install, which can be cleaned up by deleting the directory.",
 d
 )
 LOGGER.debug("ERROR", exc_info=True)
 continue
 except FileNotFoundError:
 continue

Expand Down

4 changes: 1 addition & 3 deletions
src/manage/uninstall_command.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,9 +66,7 @@ def _do_purge_global_dir(global_dir, warn_msg, *, hive=None, subkey="Environment
 if not global_dir.is_dir():
 return
 LOGGER.info("Purging global commands from %s", global_dir)
 for f in _iterdir(global_dir):
 LOGGER.debug("Purging %s", f)
 rmtree(f, after_5s_warning=warn_msg)
 rmtree(global_dir, after_5s_warning=warn_msg)


def execute(cmd):
Expand Down

12 changes: 6 additions & 6 deletions
tests/conftest.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -152,11 +152,11 @@ def localserver():


class FakeConfig:
 def __init__(self, global_dir, installs=[]):
 self.global_dir = global_dir
 self.root = global_dir.parent if global_dir else None
 self.download_dir = self.root / "_cache" if self.root else None
 self.start_folder = self.root / "_start" if self.root else None
 def __init__(self, root, installs=[]):
 self.root = self.install_dir = root
 self.global_dir = root / "bin" if root else None
 self.download_dir = root / "_cache" if root else None
 self.start_folder = root / "_start" if root else None
 self.pep514_root = REG_TEST_ROOT
 self.confirm = False
 self.installs = list(installs)
Expand DownExpand Up@@ -186,7 +186,7 @@ def ask_yn(self, question):

@pytest.fixture
def fake_config(tmp_path):
 return FakeConfig(tmp_path / "bin")
 return FakeConfig(tmp_path)


class RegistryFixture:
Expand Down

2 changes: 1 addition & 1 deletion
tests/test_uninstall_command.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ def test_purge_global_dir(monkeypatch, registry, tmp_path):
 UC._do_purge_global_dir(tmp_path, "SLOW WARNING", hive=registry.hive, subkey=registry.root)
 assert registry.getvalueandkind("", "Path") == (
 rf"C:\A;{tmp_path}\X;C:\B;%PTH%;C:\%D%\E", winreg.REG_SZ)
 assert not list(tmp_path.iterdir())
 assert not tmp_path.is_dir() or not list(tmp_path.iterdir())


def test_null_purge(fake_config):
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Avoid crashing when invalid __install__.json file exists. by zooba · Pull Request #299 · python/pymanager · GitHub
Skip to content
Avoid crashing when invalid __install__.json file exists.#299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

zooba
merged 8 commits into

from

Mar 31, 2026
 Merged


Avoid crashing when invalid __install__.json file exists.
#299
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


8 commits


Select commit
Hold shift + click to select a range
55390c5

Avoid crashing when invalid __install__.json file exists.


zooba Mar 31, 2026
c7d5b43

Improve purge to clean up unrecognised directories


zooba Mar 31, 2026
a9d2ce4

Set install_dir on test config


zooba Mar 31, 2026
2b50aaf

Use iterdir not listdir


zooba Mar 31, 2026
c99a712

Add purge to test run


zooba Mar 31, 2026
e7370ce

Simplify and use helpers


zooba Mar 31, 2026
819e54a

Allow path to be deleted in test


zooba Mar 31, 2026
d8dcd94

Don't purge everything anymore


zooba Mar 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 14 additions & 0 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -182,6 +182,20 @@ jobs:
 PYMANAGER_DEBUG: true
 shell: powershell

 - name: 'Test purge'
 run: |
 $env:PYTHON_MANAGER_CONFIG = (gi $env:PYTHON_MANAGER_CONFIG).FullName
 pymanager uninstall --purge -y
 if (Test-Path test_installs) {
 dir -r test_installs
 } else {
 Write-Host "test_installs directory has been deleted"
 }
 env:
 PYTHON_MANAGER_INCLUDE_UNMANAGED: false
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - name: 'Offline bundle download and install'
 run: |
 pymanager list --online 3 3-32 3-64 3-arm64
Expand Down

15 changes: 15 additions & 0 deletions
ci/release.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -323,6 +323,21 @@ stages:
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - powershell: |
 $env:PYTHON_MANAGER_CONFIG = (gi $env:PYTHON_MANAGER_CONFIG).FullName
 pymanager uninstall --purge -y
 if (Test-Path test_installs) {
 dir -r test_installs
 } else {
 Write-Host "test_installs directory has been deleted"
 }
 displayName: 'Test purge'
 timeoutInMinutes: 5
 env:
 PYTHON_MANAGER_INCLUDE_UNMANAGED: false
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - powershell: |
 pymanager list --online 3 3-32 3-64 3-arm64
 pymanager install --download .\bundle 3 3-32 3-64 3-arm64
Expand Down

8 changes: 8 additions & 0 deletions
src/manage/installs.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,14 @@ def _get_installs(install_dir):
 try:
 with p.open() as f:
 j = json.load(f)
 except ValueError:
 LOGGER.warn(
 "Failed to read install at %s. You may have a broken "
 "install, which can be cleaned up by deleting the directory.",
 d
 )
 LOGGER.debug("ERROR", exc_info=True)
 continue
 except FileNotFoundError:
 continue

Expand Down

4 changes: 1 addition & 3 deletions
src/manage/uninstall_command.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,9 +66,7 @@ def _do_purge_global_dir(global_dir, warn_msg, *, hive=None, subkey="Environment
 if not global_dir.is_dir():
 return
 LOGGER.info("Purging global commands from %s", global_dir)
 for f in _iterdir(global_dir):
 LOGGER.debug("Purging %s", f)
 rmtree(f, after_5s_warning=warn_msg)
 rmtree(global_dir, after_5s_warning=warn_msg)


def execute(cmd):
Expand Down

12 changes: 6 additions & 6 deletions
tests/conftest.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -152,11 +152,11 @@ def localserver():


class FakeConfig:
 def __init__(self, global_dir, installs=[]):
 self.global_dir = global_dir
 self.root = global_dir.parent if global_dir else None
 self.download_dir = self.root / "_cache" if self.root else None
 self.start_folder = self.root / "_start" if self.root else None
 def __init__(self, root, installs=[]):
 self.root = self.install_dir = root
 self.global_dir = root / "bin" if root else None
 self.download_dir = root / "_cache" if root else None
 self.start_folder = root / "_start" if root else None
 self.pep514_root = REG_TEST_ROOT
 self.confirm = False
 self.installs = list(installs)
Expand DownExpand Up@@ -186,7 +186,7 @@ def ask_yn(self, question):

@pytest.fixture
def fake_config(tmp_path):
 return FakeConfig(tmp_path / "bin")
 return FakeConfig(tmp_path)


class RegistryFixture:
Expand Down

2 changes: 1 addition & 1 deletion
tests/test_uninstall_command.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ def test_purge_global_dir(monkeypatch, registry, tmp_path):
 UC._do_purge_global_dir(tmp_path, "SLOW WARNING", hive=registry.hive, subkey=registry.root)
 assert registry.getvalueandkind("", "Path") == (
 rf"C:\A;{tmp_path}\X;C:\B;%PTH%;C:\%D%\E", winreg.REG_SZ)
 assert not list(tmp_path.iterdir())
 assert not tmp_path.is_dir() or not list(tmp_path.iterdir())


def test_null_purge(fake_config):
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Avoid crashing when invalid __install__.json file exists. by zooba · Pull Request #299 · python/pymanager · GitHub
Skip to content
Avoid crashing when invalid __install__.json file exists.#299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

zooba
merged 8 commits into

from

Mar 31, 2026
 Merged


Avoid crashing when invalid __install__.json file exists.
#299
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


8 commits


Select commit
Hold shift + click to select a range
55390c5

Avoid crashing when invalid __install__.json file exists.


zooba Mar 31, 2026
c7d5b43

Improve purge to clean up unrecognised directories


zooba Mar 31, 2026
a9d2ce4

Set install_dir on test config


zooba Mar 31, 2026
2b50aaf

Use iterdir not listdir


zooba Mar 31, 2026
c99a712

Add purge to test run


zooba Mar 31, 2026
e7370ce

Simplify and use helpers


zooba Mar 31, 2026
819e54a

Allow path to be deleted in test


zooba Mar 31, 2026
d8dcd94

Don't purge everything anymore


zooba Mar 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 14 additions & 0 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -182,6 +182,20 @@ jobs:
 PYMANAGER_DEBUG: true
 shell: powershell

 - name: 'Test purge'
 run: |
 $env:PYTHON_MANAGER_CONFIG = (gi $env:PYTHON_MANAGER_CONFIG).FullName
 pymanager uninstall --purge -y
 if (Test-Path test_installs) {
 dir -r test_installs
 } else {
 Write-Host "test_installs directory has been deleted"
 }
 env:
 PYTHON_MANAGER_INCLUDE_UNMANAGED: false
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - name: 'Offline bundle download and install'
 run: |
 pymanager list --online 3 3-32 3-64 3-arm64
Expand Down

15 changes: 15 additions & 0 deletions
ci/release.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -323,6 +323,21 @@ stages:
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - powershell: |
 $env:PYTHON_MANAGER_CONFIG = (gi $env:PYTHON_MANAGER_CONFIG).FullName
 pymanager uninstall --purge -y
 if (Test-Path test_installs) {
 dir -r test_installs
 } else {
 Write-Host "test_installs directory has been deleted"
 }
 displayName: 'Test purge'
 timeoutInMinutes: 5
 env:
 PYTHON_MANAGER_INCLUDE_UNMANAGED: false
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - powershell: |
 pymanager list --online 3 3-32 3-64 3-arm64
 pymanager install --download .\bundle 3 3-32 3-64 3-arm64
Expand Down

8 changes: 8 additions & 0 deletions
src/manage/installs.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,14 @@ def _get_installs(install_dir):
 try:
 with p.open() as f:
 j = json.load(f)
 except ValueError:
 LOGGER.warn(
 "Failed to read install at %s. You may have a broken "
 "install, which can be cleaned up by deleting the directory.",
 d
 )
 LOGGER.debug("ERROR", exc_info=True)
 continue
 except FileNotFoundError:
 continue

Expand Down

4 changes: 1 addition & 3 deletions
src/manage/uninstall_command.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,9 +66,7 @@ def _do_purge_global_dir(global_dir, warn_msg, *, hive=None, subkey="Environment
 if not global_dir.is_dir():
 return
 LOGGER.info("Purging global commands from %s", global_dir)
 for f in _iterdir(global_dir):
 LOGGER.debug("Purging %s", f)
 rmtree(f, after_5s_warning=warn_msg)
 rmtree(global_dir, after_5s_warning=warn_msg)


def execute(cmd):
Expand Down

12 changes: 6 additions & 6 deletions
tests/conftest.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -152,11 +152,11 @@ def localserver():


class FakeConfig:
 def __init__(self, global_dir, installs=[]):
 self.global_dir = global_dir
 self.root = global_dir.parent if global_dir else None
 self.download_dir = self.root / "_cache" if self.root else None
 self.start_folder = self.root / "_start" if self.root else None
 def __init__(self, root, installs=[]):
 self.root = self.install_dir = root
 self.global_dir = root / "bin" if root else None
 self.download_dir = root / "_cache" if root else None
 self.start_folder = root / "_start" if root else None
 self.pep514_root = REG_TEST_ROOT
 self.confirm = False
 self.installs = list(installs)
Expand DownExpand Up@@ -186,7 +186,7 @@ def ask_yn(self, question):

@pytest.fixture
def fake_config(tmp_path):
 return FakeConfig(tmp_path / "bin")
 return FakeConfig(tmp_path)


class RegistryFixture:
Expand Down

2 changes: 1 addition & 1 deletion
tests/test_uninstall_command.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ def test_purge_global_dir(monkeypatch, registry, tmp_path):
 UC._do_purge_global_dir(tmp_path, "SLOW WARNING", hive=registry.hive, subkey=registry.root)
 assert registry.getvalueandkind("", "Path") == (
 rf"C:\A;{tmp_path}\X;C:\B;%PTH%;C:\%D%\E", winreg.REG_SZ)
 assert not list(tmp_path.iterdir())
 assert not tmp_path.is_dir() or not list(tmp_path.iterdir())


def test_null_purge(fake_config):
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Avoid crashing when invalid __install__.json file exists. by zooba · Pull Request #299 · python/pymanager · GitHub
Skip to content
Avoid crashing when invalid __install__.json file exists.#299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

zooba
merged 8 commits into

from

Mar 31, 2026
 Merged


Avoid crashing when invalid __install__.json file exists.
#299
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


8 commits


Select commit
Hold shift + click to select a range
55390c5

Avoid crashing when invalid __install__.json file exists.


zooba Mar 31, 2026
c7d5b43

Improve purge to clean up unrecognised directories


zooba Mar 31, 2026
a9d2ce4

Set install_dir on test config


zooba Mar 31, 2026
2b50aaf

Use iterdir not listdir


zooba Mar 31, 2026
c99a712

Add purge to test run


zooba Mar 31, 2026
e7370ce

Simplify and use helpers


zooba Mar 31, 2026
819e54a

Allow path to be deleted in test


zooba Mar 31, 2026
d8dcd94

Don't purge everything anymore


zooba Mar 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 14 additions & 0 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -182,6 +182,20 @@ jobs:
 PYMANAGER_DEBUG: true
 shell: powershell

 - name: 'Test purge'
 run: |
 $env:PYTHON_MANAGER_CONFIG = (gi $env:PYTHON_MANAGER_CONFIG).FullName
 pymanager uninstall --purge -y
 if (Test-Path test_installs) {
 dir -r test_installs
 } else {
 Write-Host "test_installs directory has been deleted"
 }
 env:
 PYTHON_MANAGER_INCLUDE_UNMANAGED: false
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - name: 'Offline bundle download and install'
 run: |
 pymanager list --online 3 3-32 3-64 3-arm64
Expand Down

15 changes: 15 additions & 0 deletions
ci/release.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -323,6 +323,21 @@ stages:
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - powershell: |
 $env:PYTHON_MANAGER_CONFIG = (gi $env:PYTHON_MANAGER_CONFIG).FullName
 pymanager uninstall --purge -y
 if (Test-Path test_installs) {
 dir -r test_installs
 } else {
 Write-Host "test_installs directory has been deleted"
 }
 displayName: 'Test purge'
 timeoutInMinutes: 5
 env:
 PYTHON_MANAGER_INCLUDE_UNMANAGED: false
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - powershell: |
 pymanager list --online 3 3-32 3-64 3-arm64
 pymanager install --download .\bundle 3 3-32 3-64 3-arm64
Expand Down

8 changes: 8 additions & 0 deletions
src/manage/installs.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,14 @@ def _get_installs(install_dir):
 try:
 with p.open() as f:
 j = json.load(f)
 except ValueError:
 LOGGER.warn(
 "Failed to read install at %s. You may have a broken "
 "install, which can be cleaned up by deleting the directory.",
 d
 )
 LOGGER.debug("ERROR", exc_info=True)
 continue
 except FileNotFoundError:
 continue

Expand Down

4 changes: 1 addition & 3 deletions
src/manage/uninstall_command.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,9 +66,7 @@ def _do_purge_global_dir(global_dir, warn_msg, *, hive=None, subkey="Environment
 if not global_dir.is_dir():
 return
 LOGGER.info("Purging global commands from %s", global_dir)
 for f in _iterdir(global_dir):
 LOGGER.debug("Purging %s", f)
 rmtree(f, after_5s_warning=warn_msg)
 rmtree(global_dir, after_5s_warning=warn_msg)


def execute(cmd):
Expand Down

12 changes: 6 additions & 6 deletions
tests/conftest.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -152,11 +152,11 @@ def localserver():


class FakeConfig:
 def __init__(self, global_dir, installs=[]):
 self.global_dir = global_dir
 self.root = global_dir.parent if global_dir else None
 self.download_dir = self.root / "_cache" if self.root else None
 self.start_folder = self.root / "_start" if self.root else None
 def __init__(self, root, installs=[]):
 self.root = self.install_dir = root
 self.global_dir = root / "bin" if root else None
 self.download_dir = root / "_cache" if root else None
 self.start_folder = root / "_start" if root else None
 self.pep514_root = REG_TEST_ROOT
 self.confirm = False
 self.installs = list(installs)
Expand DownExpand Up@@ -186,7 +186,7 @@ def ask_yn(self, question):

@pytest.fixture
def fake_config(tmp_path):
 return FakeConfig(tmp_path / "bin")
 return FakeConfig(tmp_path)


class RegistryFixture:
Expand Down

2 changes: 1 addition & 1 deletion
tests/test_uninstall_command.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ def test_purge_global_dir(monkeypatch, registry, tmp_path):
 UC._do_purge_global_dir(tmp_path, "SLOW WARNING", hive=registry.hive, subkey=registry.root)
 assert registry.getvalueandkind("", "Path") == (
 rf"C:\A;{tmp_path}\X;C:\B;%PTH%;C:\%D%\E", winreg.REG_SZ)
 assert not list(tmp_path.iterdir())
 assert not tmp_path.is_dir() or not list(tmp_path.iterdir())


def test_null_purge(fake_config):
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Avoid crashing when invalid __install__.json file exists. by zooba · Pull Request #299 · python/pymanager · GitHub
Skip to content
Avoid crashing when invalid __install__.json file exists.#299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

zooba
merged 8 commits into

from

Mar 31, 2026
 Merged


Avoid crashing when invalid __install__.json file exists.
#299
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


8 commits


Select commit
Hold shift + click to select a range
55390c5

Avoid crashing when invalid __install__.json file exists.


zooba Mar 31, 2026
c7d5b43

Improve purge to clean up unrecognised directories


zooba Mar 31, 2026
a9d2ce4

Set install_dir on test config


zooba Mar 31, 2026
2b50aaf

Use iterdir not listdir


zooba Mar 31, 2026
c99a712

Add purge to test run


zooba Mar 31, 2026
e7370ce

Simplify and use helpers


zooba Mar 31, 2026
819e54a

Allow path to be deleted in test


zooba Mar 31, 2026
d8dcd94

Don't purge everything anymore


zooba Mar 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 14 additions & 0 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -182,6 +182,20 @@ jobs:
 PYMANAGER_DEBUG: true
 shell: powershell

 - name: 'Test purge'
 run: |
 $env:PYTHON_MANAGER_CONFIG = (gi $env:PYTHON_MANAGER_CONFIG).FullName
 pymanager uninstall --purge -y
 if (Test-Path test_installs) {
 dir -r test_installs
 } else {
 Write-Host "test_installs directory has been deleted"
 }
 env:
 PYTHON_MANAGER_INCLUDE_UNMANAGED: false
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - name: 'Offline bundle download and install'
 run: |
 pymanager list --online 3 3-32 3-64 3-arm64
Expand Down

15 changes: 15 additions & 0 deletions
ci/release.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -323,6 +323,21 @@ stages:
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - powershell: |
 $env:PYTHON_MANAGER_CONFIG = (gi $env:PYTHON_MANAGER_CONFIG).FullName
 pymanager uninstall --purge -y
 if (Test-Path test_installs) {
 dir -r test_installs
 } else {
 Write-Host "test_installs directory has been deleted"
 }
 displayName: 'Test purge'
 timeoutInMinutes: 5
 env:
 PYTHON_MANAGER_INCLUDE_UNMANAGED: false
 PYTHON_MANAGER_CONFIG: .\test-config.json
 PYMANAGER_DEBUG: true

 - powershell: |
 pymanager list --online 3 3-32 3-64 3-arm64
 pymanager install --download .\bundle 3 3-32 3-64 3-arm64
Expand Down

8 changes: 8 additions & 0 deletions
src/manage/installs.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,14 @@ def _get_installs(install_dir):
 try:
 with p.open() as f:
 j = json.load(f)
 except ValueError:
 LOGGER.warn(
 "Failed to read install at %s. You may have a broken "
 "install, which can be cleaned up by deleting the directory.",
 d
 )
 LOGGER.debug("ERROR", exc_info=True)
 continue
 except FileNotFoundError:
 continue

Expand Down

4 changes: 1 addition & 3 deletions
src/manage/uninstall_command.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,9 +66,7 @@ def _do_purge_global_dir(global_dir, warn_msg, *, hive=None, subkey="Environment
 if not global_dir.is_dir():
 return
 LOGGER.info("Purging global commands from %s", global_dir)
 for f in _iterdir(global_dir):
 LOGGER.debug("Purging %s", f)
 rmtree(f, after_5s_warning=warn_msg)
 rmtree(global_dir, after_5s_warning=warn_msg)


def execute(cmd):
Expand Down

12 changes: 6 additions & 6 deletions
tests/conftest.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -152,11 +152,11 @@ def localserver():


class FakeConfig:
 def __init__(self, global_dir, installs=[]):
 self.global_dir = global_dir
 self.root = global_dir.parent if global_dir else None
 self.download_dir = self.root / "_cache" if self.root else None
 self.start_folder = self.root / "_start" if self.root else None
 def __init__(self, root, installs=[]):
 self.root = self.install_dir = root
 self.global_dir = root / "bin" if root else None
 self.download_dir = root / "_cache" if root else None
 self.start_folder = root / "_start" if root else None
 self.pep514_root = REG_TEST_ROOT
 self.confirm = False
 self.installs = list(installs)
Expand DownExpand Up@@ -186,7 +186,7 @@ def ask_yn(self, question):

@pytest.fixture
def fake_config(tmp_path):
 return FakeConfig(tmp_path / "bin")
 return FakeConfig(tmp_path)


class RegistryFixture:
Expand Down

2 changes: 1 addition & 1 deletion
tests/test_uninstall_command.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ def test_purge_global_dir(monkeypatch, registry, tmp_path):
 UC._do_purge_global_dir(tmp_path, "SLOW WARNING", hive=registry.hive, subkey=registry.root)
 assert registry.getvalueandkind("", "Path") == (
 rf"C:\A;{tmp_path}\X;C:\B;%PTH%;C:\%D%\E", winreg.REG_SZ)
 assert not list(tmp_path.iterdir())
 assert not tmp_path.is_dir() or not list(tmp_path.iterdir())


def test_null_purge(fake_config):
Expand Down
Loading