Skip to content

Add tomli_loads benchmark - #200

Merged
kumaraditya303 merged 12 commits into
python:mainfrom
kumaraditya303:tomllib
Apr 7, 2023
Merged

Add tomli_loads benchmark#200
kumaraditya303 merged 12 commits into
python:mainfrom
kumaraditya303:tomllib

Conversation

@kumaraditya303

@kumaraditya303kumaraditya303 commented May 14, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@kumaraditya303

kumaraditya303 commented May 14, 2022

Copy link
Copy Markdown
ContributorAuthor

It seems like requires-python = ">=3.11" has no effect and seems broken.

@kumaraditya303
kumaraditya303 marked this pull request as ready for review May 14, 2022 08:14
ericsnowcurrently
ericsnowcurrently requested changes May 24, 2022
View reviewed changes

@ericsnowcurrentlyericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! It mostly LGTM. There's only one thing I'd like added.

Comment threadpyperformance/data-files/benchmarks/bm_tomllib_loads/run_benchmark.py Outdated
ericsnowcurrently
ericsnowcurrently approved these changes May 27, 2022
View reviewed changes

@ericsnowcurrentlyericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for working on this.

Comment threadpyperformance/data-files/benchmarks/bm_tomllib_loads/generate_data.py Outdated
@kumaraditya303@ericsnowcurrently
Update pyperformance/data-files/benchmarks/bm_tomllib_loads/generate_…
1f27ef1
…data.py
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@ericsnowcurrentlyericsnowcurrently removed their assignment Jun 10, 2022
@ericsnowcurrently

ericsnowcurrently commented Jun 10, 2022

Copy link
Copy Markdown
Member

We can merge this once the tests are passing. Do you know what the problem is?

@kumaraditya303

kumaraditya303 commented Jun 10, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

See #200 (comment)

The issue is that requires-python metadata has no effect.

@ericsnowcurrently

ericsnowcurrently commented Jun 10, 2022

Copy link
Copy Markdown
Member

Ah, right. I'll take a look at that real quick and then merge it.

@mdboom

mdboom commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

Maybe we should have this install toml from PyPI instead of only using the stdlib one? That would give us more Python version coverage.

@hauntsaninja

hauntsaninja commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

(tomllib is based on pypi's tomli, not toml)

@AlexWaygoodAlexWaygood mentioned this pull request Mar 1, 2023
Open
@kumaraditya303kumaraditya303 changed the title Add tomllib.loads benchmarkAdd tomli_loads benchmarkApr 7, 2023
@kumaraditya303
kumaraditya303 merged commit 9c58774 into python:mainApr 7, 2023
@kumaraditya303
kumaraditya303 deleted the tomllib branch April 7, 2023 07:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kumaraditya303@ericsnowcurrently@mdboom@hauntsaninja