Uh oh!
There was an error while loading. Please reload this page.
Add benchmark for deepcopy - #201
Conversation
ericsnowcurrently
left a comment
There was a problem hiding this comment.
This looks mostly good. Aside from a few linting issues, there are only a couple small concerns.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
a83c0a4 to
a777604Compareeendebakpt
commented
May 31, 2022
@ericsnowcurrently Changes made. |
ericsnowcurrently
commented
May 31, 2022
Thanks, @eendebakpt. I'll take a look as soon as I can. |
ericsnowcurrently
left a comment
There was a problem hiding this comment.
Mostly LGTM. There are a few really minor things that I won't even bother mentioning. 😄 The only thing worth looking at is the overhead of everything going on the in the various loops in the one benchmark. My recommendation doesn't impact readability all that much so you might as well apply it, just in case.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
ericsnowcurrently
commented
Jun 7, 2022
Thanks for the benchmark, @eendebakpt! |
One python method that is currently not in the pyperformance benchmarks is
deepcopy. This PRs adds a benchmark that tests performance ofdeepcopyon a nested dictionary and a dataclass.The dictionary and dataclass have been chosen as example of structures can are often copied and then modified. (e.g. passing configuration settings to a method that modifies one of the settings before passing it on)
Fixes#199