Uh oh!
There was an error while loading. Please reload this page.
Add coverage benchmark - #213
Conversation
gvanrossum
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing something about this.
Question for @kumaraditya303 -- Have you actually tried this before and after the regression you mentioned as example?
Question for @ericsnowcurrently -- Do you agree this is useful?
kumaraditya303
commented
Jun 6, 2022
@gvanrossum: The regression I linked above 1 is not caused by a single change but rather accumulation of multiple slowdown caused by multiple changes of which the most significant ones being python/cpython#91666 and python/cpython#27077. Since there is no benchmark in pyperformance to exercise coverage performance, the slowdown was unnoticed. Once this benchmark is added, it will help us pinpoint which commits caused the most slowdown with a simple Footnotes |
gvanrossum
commented
Jun 6, 2022
Nevertheless it would be interesting to see the numbers of running this BM on the state before and after said commits to demonstrate its usefulness. |
kumaraditya303
commented
Jun 6, 2022
I am running the benchmarks now, will post soon. |
kumaraditya303
commented
Jun 6, 2022
@gvanrossum Benchmarking before and after python/cpython@944fffe commit Results:
|
ericsnowcurrently
commented
Jun 6, 2022
Yeah, it's a helpful indicator of impact. |
Add a coverage benchmark to help benchmarking and avoid regressions such as python/cpython#93516.
Benchmark result 3.10 vs 3.12 main branch.