Skip to content

gh-263: Run Python 3.12 task as the experimental task - #274

Merged
corona10 merged 15 commits into
python:mainfrom
corona10:optional_312
Apr 19, 2023
Merged

gh-263: Run Python 3.12 task as the experimental task#274
corona10 merged 15 commits into
python:mainfrom
corona10:optional_312

Conversation

@corona10

@corona10corona10 commented Apr 19, 2023•
edited
Loading

Copy link
Copy Markdown
Member

@corona10corona10 changed the title gh-263: Run Python 3.12 task as the experimental task[WIP] gh-263: Run Python 3.12 task as the experimental taskApr 19, 2023
@corona10
corona10force-pushed the optional_312 branch 2 times, most recently from e23b679 to edfc331CompareApril 19, 2023 08:21
@corona10
corona10 marked this pull request as ready for review April 19, 2023 10:39
@corona10corona10 changed the title [WIP] gh-263: Run Python 3.12 task as the experimental taskgh-263: Run Python 3.12 task as the experimental taskApr 19, 2023
@corona10corona10 mentioned this pull request Apr 19, 2023
Closed
hugovk
hugovk approved these changes Apr 19, 2023
View reviewed changes

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little nits but looks good :)

Note for others, looks like we need to merge this first for it to pass:
#263 (comment)

Comment thread.github/workflows/main.yml Outdated
Comment thread.github/workflows/main.yml Outdated
Comment thread.github/workflows/main.yml Outdated
corona10and others added 3 commits April 19, 2023 21:34
@corona10@hugovk
Update .github/workflows/main.yml
49a6ff8
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@corona10@hugovk
Update .github/workflows/main.yml
065be27
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@corona10@hugovk
Update .github/workflows/main.yml
4e7712c
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@corona10
corona10 merged commit fe07325 into python:mainApr 19, 2023
@hugovkhugovk mentioned this pull request Apr 20, 2023
Closed
@hugovkhugovk mentioned this pull request Apr 20, 2023
Closed
This was referenced Oct 19, 2023
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes
@gvanrossumgvanrossumAwaiting requested review from gvanrossum

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@corona10@hugovk