Uh oh!
There was an error while loading. Please reload this page.
gh-287: Add TaskGroups variants to async_tree benchmarks - #293
Merged
Conversation
itamaro
commented
May 27, 2023
ContributorAuthor
cc @kumaraditya303 you were interested in this |
Uh oh!
There was an error while loading. Please reload this page.
kumaraditya303
approved these changes
Jun 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 8 new async_tree benchmark variants covering TaskGroups usage for the 8 original variants.
In addition, I also added asyncio tags to all these benchmarks, and added a requires-python field to restrict the TaskGroups variants to >=3.11 and the eager variants to >=3.12.
fixedgh-287