Uh oh!
There was an error while loading. Please reload this page.
Add ruff format to pre-commit, run it, except the benchmarks - #410
Conversation
ruff formatruff format to pre-commit, run it, except the benchmarksUh oh!
There was an error while loading. Please reload this page.
@hugovk Did you review and not submit? Not pushing in any way. I see nothing here but you were active and there's "Apply suggestions" label on "My work" tab: ![]() |
hugovk
commented
Sep 8, 2025
Yes, I started a review but didn't finish yet :) Interesting GH says there are suggestions when they're not visible or actionable yet. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
There was a problem hiding this comment.
Thank you for a great and careful review!
I've addressed all the comments. Also, I ensured that the GitHub Action and .pre-commit-config.yaml use the latest plugins.
Is there are any list of recommended Ruff rules? For example, RUF022 is not particularly popular. Generally, which projects have the most referential pyproject.toml?
Uh oh!
There was an error while loading. Please reload this page.
hugovk
left a comment
There was a problem hiding this comment.
Is there are any list of recommended Ruff rules?
Not really.
For example, RUF022 is not particularly popular. Generally, which projects have the most referential pyproject.toml?
Of those linked, I help maintain cherry-picker and python-docs-theme.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
left a comment
There was a problem hiding this comment.
Thanks! I'll leave this a bit to see if anyone else has suggestions.
hugovk
commented
Sep 22, 2025
10 days is long enough, let's merge. Thanks! |
Uh oh!
There was an error while loading. Please reload this page.
* main: Add `ruff format` to pre-commit, run it, except the benchmarks (python#410)
…n#410) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

This should be the last one from this series:
#405 (comment)