Uh oh!
There was an error while loading. Please reload this page.
Add bm_base64 covering common base64 module APIs - #447
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
serhiy-storchaka
left a comment
There was a problem hiding this comment.
What are the results and the total time?
My suggestions:
- Test an ASCII string input for decoding.
- Balance encoding and decoding.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
per review from Serhiy.
gpshead
commented
Jan 2, 2026
Example results comparing before and after python/cpython#143262. |
serhiy-storchaka
left a comment
There was a problem hiding this comment.
I am going to add also ignorechars to support decoding multi-line data. So it may be worth to separate "raw" and "multi-line" cases, if we want to compare the effect of optimization. We could also separate encoding and decoding. But then we will have too much tests. So this is up to you.
gpshead
commented
Jan 3, 2026
yeah i'd initially started out with separate encode/decode but the matrix of benchmark cases got large and pyperformance is not really intended as a microbenchmark. improvements in any of these will be reflected in the overall scores. |
Uh oh!
There was an error while loading. Please reload this page.
* main: Replace pre-commit with prek in CI and add cooldown to Dependabot (python#452) Add bm_base64 covering common base64 module APIs (python#447)
Motivation python/cpython#143262 but also in general this wasn't covered and @serhiy-storchaka is also doing work in this area that'll become relevant such as python/cpython#143216.