Split linting from main workflow by m-aciek · Pull Request #144 · python/python-docs-pl

m-aciek · 2026-06-08T09:36:02Z

By splitting workflows we get a better, gradual feedback and state of things expression.

Building without strict mode, we can add back strict mode as a separate workflow (or as part of linting?) in the future.

Updated READMEs with new workflow links. Extra changes: dropped translations mailing list and added a link to Sphinx translation.

Unable to test workflow run trigger before the PR is merged into main.

To do:

(optionally) find out why 3.15 pdf build fails (without -W flag); corresponding job called with make dist-pdf doesn't fail: https://github.com/m-aciek/python-docs-offline/actions/runs/27127952047/job/80061499030
- retry 3.15 latex generation and failed job after 3.15 backport of linked fix is merged

…uild workflow

m-aciek · 2026-06-11T14:11:28Z

Posted a PR fixing the failure cause: python/cpython#151343

StanFromIreland · 2026-06-11T15:14:34Z

Posted a PR fixing the failure cause: python/cpython#151343

Thanks, merged!

for more information, see https://pre-commit.ci

StanFromIreland · 2026-06-12T10:42:20Z

 - run: git add .
 - run: git commit -m "$(python manage_translation.py generate_commit_msg)"
 if: env.SIGNIFICANT_CHANGES
 - name: Push commit


This shouldn't run on PRs IMO. This causes issues like https://github.com/python/python-docs-pl/actions/runs/27407678283/job/81000784306?pr=144.

added a skip

…d command

…t correct permissions, add run-id and auth to download artifact job

m-aciek · 2026-06-24T09:21:58Z

@copilot resolve the merge conflicts in this pull request

StanFromIreland · 2026-06-24T09:24:37Z

Oh no, sorry this slipped my mind. I'll review later today.

python-cla-bot · 2026-06-24T09:25:00Z

The following commit authors need to sign the Contributor License Agreement:

198982749+Copilot@users.noreply.github.com

Copilot · 2026-06-24T09:26:09Z

@copilot resolve the merge conflicts in this pull request

Resolved in b1e0efc. The conflicts were in the auto-generated badge stats sections of both README files — took the newer translation percentages from 3.15 while keeping the lint.yml workflow link from this branch.

StanFromIreland · 2026-06-24T10:14:44Z

 - name: Push commit
 uses: ad-m/github-push-action@881a6320fdb16eb5318c5054f31c218aec2b324c # v1.3.0
- if: env.SIGNIFICANT_CHANGES
+ if: env.SIGNIFICANT_CHANGES && (github.event.workflow_run.head_branch == github.event.repository.default_branch)


There's no workflow_run trigger?

Co-authored-by: Stan Ulbrych <stanulbrych@gmail.com>

m-aciek · 2026-06-26T07:39:55Z

@copilot resolve the merge conflicts in this pull request

Copilot · 2026-06-26T07:41:52Z

@copilot resolve the merge conflicts in this pull request

Resolved in 6bd439f — merged 3.15 into this branch, keeping the lint.yml workflow URL and the newer translation stats from HEAD.

StanFromIreland

LGTM

Co-authored-by: Stan Ulbrych <stanulbrych@gmail.com>

m-aciek added 6 commits June 6, 2026 14:11

Split linting jobs into a separate workflow file
9a6855e

Set SPHINXERRORHANDLING environment variable to 0 in build workflow
c54b55a

Set SPHINXERRORHANDLING environment variable to '' in build workflow
d0ab3ba

Remove fail-on-warning flag from Sphinx build options in update-and-b…
08b7f0b
…uild workflow

Install librsvg2-bin in output-pdf step
de91514

Disable fail-fast in output-pdf job strategy
9a081e8

StanFromIreland reviewed Jun 11, 2026
View reviewed changes

Comment thread.github/workflows/lint.yml Outdated

m-aciekand others added 5 commits June 11, 2026 19:50

Update lint.yml
24516e4

[pre-commit.ci] auto fixes from pre-commit.com hooks
2c4d6f4
for more information, see https://pre-commit.ci

Update README.md
2ac3748

Update README.en.md
9577fed

Update update-and-build.yml, partial revert
79d6f8b

m-aciek marked this pull request as ready for review June 11, 2026 19:41

m-aciek requested a review from StanFromIreland June 11, 2026 19:43

m-aciek added 3 commits June 12, 2026 11:37

Update README files to link to the new lint workflow
977eacf

Remove Python translations mailing list link from README files
cf76331

Add Sphinx translation link to README files
db9f6e9

StanFromIreland reviewed Jun 12, 2026
View reviewed changes

Comment thread.github/workflows/lint.yml
Comment thread.github/workflows/update-and-build.yml Outdated
Comment thread.github/workflows/lint.yml

m-aciek added 3 commits June 12, 2026 15:35

Refactor linting workflow to remove unnecessary flag from Sphinx buil…
ee89d94
…d command

skip pushing out of default branch, skip linting on non-successes, se…
378d5ec
…t correct permissions, add run-id and auth to download artifact job

Merge branch '3.15' into split-linting-from-main-workflow
89e49b6

m-aciek requested a review from StanFromIreland June 15, 2026 22:01

Copilotstarted work on behalf of m-aciek June 24, 2026 09:22 View session

Initial state - resolving merge conflicts
3076a9a

Resolve merge conflicts in README.md and README.en.md
b1e0efc

Copilotfinished work on behalf of m-aciek June 24, 2026 09:26

StanFromIreland reviewed Jun 24, 2026
View reviewed changes

m-aciekand others added 2 commits June 26, 2026 09:31

Don't skip source linting on update/push failure
6b281a7
Co-authored-by: Stan Ulbrych <stanulbrych@gmail.com>

Fix skipping non-default branches for push
88f0c3c

Copilotstarted work on behalf of m-aciek June 26, 2026 07:40 View session

Merge branch '3.15' into split-linting-from-main-workflow
6bd439f

Copilotfinished work on behalf of m-aciek June 26, 2026 07:42

m-aciek requested a review from StanFromIreland June 26, 2026 08:28

StanFromIreland approved these changes Jun 26, 2026
View reviewed changes

Comment thread.github/workflows/lint.yml Outdated

Unify python-version in setup step
fafb4a3
Co-authored-by: Stan Ulbrych <stanulbrych@gmail.com>

m-aciek merged commit e705c94 into 3.15Jun 27, 2026
7 of 8 checks passed

m-aciek deleted the split-linting-from-main-workflow branch June 27, 2026 12:17

Uh oh!

Uh oh!

Conversation

m-aciek commented Jun 8, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m-aciek commented Jun 11, 2026

Uh oh!

StanFromIreland commented Jun 11, 2026

Uh oh!

Uh oh!

StanFromIrelandJun 12, 2026

Choose a reason for hiding this comment

Uh oh!

m-aciekJun 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

m-aciek commented Jun 24, 2026

Uh oh!

StanFromIreland commented Jun 24, 2026

Uh oh!

python-cla-botBot commented Jun 24, 2026

Uh oh!

CopilotAI commented Jun 24, 2026

Uh oh!

StanFromIrelandJun 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

m-aciek commented Jun 26, 2026

Uh oh!

CopilotAI commented Jun 26, 2026

Uh oh!

StanFromIreland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

m-aciek commented Jun 8, 2026•
edited
Loading