Skip to content

Dark mode: fix contrast of footer highlight - #162

Merged
hugovk merged 1 commit into
python:mainfrom
hugovk:fix-dark-mode-footer-highlight-contrast
Dec 4, 2023
Merged

Dark mode: fix contrast of footer highlight#162
hugovk merged 1 commit into
python:mainfrom
hugovk:fix-dark-mode-footer-highlight-contrast

Conversation

@hugovk

@hugovkhugovk commented Dec 3, 2023

Copy link
Copy Markdown
Member

@hugovkhugovk added the bug label Dec 3, 2023
@hugovk
hugovk merged commit 2c4de5a into python:mainDec 4, 2023
@hugovk
hugovk deleted the fix-dark-mode-footer-highlight-contrast branch December 4, 2023 18:11
@ferdnyc

Copy link
Copy Markdown

Hah! I was just coming here to get started on a similar pull request.

Unfortunately, while this is merged, it still isn't deployed on docs.python.org. Those docs still show the unreadable yellow background, in the dark theme.

Is there a procedure for getting the live docs to pull in theme updates?

@hugovk

Copy link
Copy Markdown
MemberAuthor

Hah! I was just coming here to get started on a similar pull request.

Thank you!

Is there a procedure for getting the live docs to pull in theme updates?

Yes, the procedure is:

We have a few thing pending release, I'll make one later today or this weekend.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark mode: highlighted footnote unreadable

3 participants

@hugovk@ferdnyc@ezio-melotti