Skip to content

Consistently reference theme_root_icon - #163

Merged
AA-Turner merged 6 commits into
python:mainfrom
mbudisic:layout_reads_root_icon
Jan 12, 2024
Merged

Consistently reference theme_root_icon#163
AA-Turner merged 6 commits into
python:mainfrom
mbudisic:layout_reads_root_icon

Conversation

@mbudisic

Copy link
Copy Markdown
Contributor

Removed explicit py.svg references in layout.html with theme_root_icon paths.

This pull request changes paths lines 17 and 103 to match line 74 in the base branch.

Removed explicit py.svg references with theme_root_icon paths
@ghost

ghost commented Jan 9, 2024

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@hugovk

Copy link
Copy Markdown
Member

Good idea.

Although "Logo" isn't a great alt text, can we also add something like root_icon_alt_text to the config?

@mbudisic
mbudisicforce-pushed the layout_reads_root_icon branch from 310da0a to 7c36c8eCompareJanuary 10, 2024 20:40
… layout.html
This fixes a partial integration of root_icon and adds the new variable root_icon_alt_text
@mbudisic
mbudisicforce-pushed the layout_reads_root_icon branch from 7c36c8e to 099019dCompareJanuary 10, 2024 20:47
Comment threadpython_docs_theme/theme.conf Outdated
Capitalization fix
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mbudisic

Copy link
Copy Markdown
ContributorAuthor

Thank you for suggestions!

Comment threadpython_docs_theme/theme.conf
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

@AA-TurnerAA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the documentation:

This, however, is not the preferred way to concatenate strings! For string concatenation, have a look-see at the ~ operator.

https://jinja.palletsprojects.com/en/3.1.x/templates/#other-operators

~ (tilde)

Converts all operands into strings and concatenates them.

As

Comment threadpython_docs_theme/layout.html Outdated
Comment threadpython_docs_theme/layout.html Outdated
@AA-TurnerAA-Turner changed the title layout.html references theme_root_icon consistentlyConsistently reference theme_root_iconJan 12, 2024
@AA-Turner
AA-Turner merged commit beb868f into python:mainJan 12, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mbudisic@hugovk@AA-Turner@ezio-melotti