Skip to content

Require Python 3.10 and Sphinx 7.3 - #221

Merged
AA-Turner merged 8 commits into
python:mainfrom
AA-Turner:drop-reqs
Feb 13, 2025
Merged

Require Python 3.10 and Sphinx 7.3#221
AA-Turner merged 8 commits into
python:mainfrom
AA-Turner:drop-reqs

Conversation

@AA-Turner

@AA-TurnerAA-Turner commented Feb 2, 2025

Copy link
Copy Markdown
Member

See also python/cpython#129576. This would mean this theme is no longer installable with the 3.10 or 3.11 branches, which require sphinx==3.4.3 and sphinx~=7.2.0 respectively.

Changes:

  • Require Python 3.10 (used on the docs server)
  • Require Sphinx 7.3
  • Drop _add_asset_hashes patch
  • Drop CSS for Sphinx 4.x
  • Drop sidebar.js_t for Sphinx 4.x
  • Add static type annotations to setup()
  • Convert theme.conf to the new theme.toml (via python -m sphinx.theming conf_to_toml python_docs_theme)
  • Define the versionextension metadata field.
  • Replace @import url(...) with an entry in the sidebars list, to allow parallel stylesheet fetching by the user agent

A


📚 Documentation preview 📚: https://python-docs-theme-previews--221.org.readthedocs.build/

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(There's a conflict after merging #219.)

Looking good, although before merging and pinning 3.11 to 2024.12 in python/cpython#129576, it might be nice to get #218 merged and released in 2025.2, and then pinning 3.11 to 2025.2?

Comment threadpython_docs_theme/__init__.py Outdated
Comment threadpython_docs_theme/__init__.py
@AA-TurnerAA-Turner mentioned this pull request Feb 4, 2025
# Conflicts:
#	python_docs_theme/__init__.py
#	python_docs_theme/static/pydoctheme.css

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AA-Turner

Copy link
Copy Markdown
MemberAuthor

3.10 & 3.11 are now pinned to 2025.2, so merging this.

A

@AA-Turner
AA-Turner merged commit f5d080f into python:mainFeb 13, 2025
@AA-Turner
AA-Turner deleted the drop-reqs branch February 13, 2025 01:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AA-Turner@hugovk