Skip to content

Enable theme translation - #246

Merged
hugovk merged 10 commits into
python:mainfrom
StanFromIreland:localize-theme
Sep 7, 2025
Merged

Enable theme translation#246
hugovk merged 10 commits into
python:mainfrom
StanFromIreland:localize-theme

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Aug 7, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Adds Polish to start. Based on @rffontenelle 's pr. This does not allow for translation of the Copy button for some reason, but I think that can be left for another time.

Result:

image

📚 Documentation preview 📚: https://python-docs-theme-previews--246.org.readthedocs.build/

🇵🇱 Polish preview 🇵🇱

@StanFromIreland
StanFromIreland marked this pull request as ready for review August 7, 2025 15:12
@StanFromIreland
StanFromIreland marked this pull request as draft August 7, 2025 15:13
@StanFromIreland
StanFromIreland marked this pull request as ready for review August 7, 2025 17:19
@StanFromIrelandStanFromIreland changed the title Localize themeEnable theme translationAug 7, 2025
@rffontenellerffontenelle mentioned this pull request Aug 7, 2025
Closed
@rffontenelle

rffontenelle commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Thanks for fixing what was missing with the solution!

@rffontenellerffontenelle mentioned this pull request Aug 8, 2025
Closed
m-aciek
m-aciek reviewed Aug 8, 2025
View reviewed changes

@m-aciekm-aciek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation improvement suggestions, otherwise looks good to me 👍

Comment threadpython_docs_theme/locales/pl_PL/LC_MESSAGES/messages.po Outdated
Comment threadpython_docs_theme/locales/pl_PL/LC_MESSAGES/messages.po Outdated
Comment threadpython_docs_theme/locales/pl_PL/LC_MESSAGES/messages.po Outdated
Comment threadpython_docs_theme/locales/pl_PL/LC_MESSAGES/messages.po Outdated
Comment threadpython_docs_theme/locales/pl_PL/LC_MESSAGES/messages.po Outdated
m-aciek
m-aciek reviewed Aug 9, 2025
View reviewed changes

@m-aciekm-aciek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for better portability

Comment threadpython_docs_theme/__init__.py Outdated
@StanFromIreland@m-aciek
Apply suggestions from Maciek
49f99d8
Co-authored-by: Maciej Olko <maciej.olko@gmail.com>
yeager added a commit to yeager/python-docs-theme that referenced this pull request Aug 29, 2025
@yeager
Adding Swedish translation
6ba31eb
Pre-req python#246
@yeageryeager mentioned this pull request Aug 29, 2025
Merged
hugovk
hugovk reviewed Sep 2, 2025
View reviewed changes

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right, but I'd appreciate a PR approval from a translator as well.

And we can always iterate and fix as needed after an initial release.

Comment threadbabel_runner.py Outdated
Comment threadbabel_runner.py
AA-Turner
AA-Turner reviewed Sep 2, 2025
View reviewed changes
Comment threadpython_docs_theme/__init__.py Outdated
AA-Turner
AA-Turner reviewed Sep 2, 2025
View reviewed changes
Comment threadpython_docs_theme/locales/pl_PL/LC_MESSAGES/messages.mo Outdated
@StanFromIreland

StanFromIreland commented Sep 2, 2025

Copy link
Copy Markdown
MemberAuthor

Looks about right, but I'd appreciate a PR approval from a translator as well.

Maciek has already reviewed translation, see above.

hugovk
hugovk reviewed Sep 2, 2025
View reviewed changes
Comment threadpython_docs_theme/locales/pl_PL/LC_MESSAGES/messages.po
@hugovk

hugovk commented Sep 2, 2025

Copy link
Copy Markdown
Member

Looks about right, but I'd appreciate a PR approval from a translator as well.

Maciek has already reviewed translation, see above.

Yes, but not approved.

@StanFromIreland

StanFromIreland commented Sep 2, 2025

Copy link
Copy Markdown
MemberAuthor

In hopes of getting this in faster, I can just delete it?

Fun fact, translations of the Python docs are actually not reviewed for most languages.

@StanFromIreland

StanFromIreland commented Sep 2, 2025

Copy link
Copy Markdown
MemberAuthor

Preview! (built with -D language='pl')

m-aciek
m-aciek approved these changes Sep 2, 2025
View reviewed changes

@m-aciekm-aciek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

Comment thread.gitignore
Comment threadbabel_runner.py
hugovk
hugovk reviewed Sep 3, 2025
View reviewed changes
Comment thread.gitignore
Comment threadpython_docs_theme/locales/pl_PL/LC_MESSAGES/messages.mo Outdated
@StanFromIreland

StanFromIreland commented Sep 3, 2025

Copy link
Copy Markdown
MemberAuthor

It is no longer a follow up, it is now included in this PR!

Verified manually that the artefact has the compiled files.

@StanFromIrelandStanFromIreland mentioned this pull request Sep 3, 2025
Closed
@rffontenelle

rffontenelle commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

Sweet! Was setup-python really necessary, considering that python is already included in the GH runner image?

@StanFromIreland

StanFromIreland commented Sep 3, 2025

Copy link
Copy Markdown
MemberAuthor

It is used in all other workflows in this repository when Python is needed.

hugovk
hugovk approved these changes Sep 5, 2025
View reviewed changes

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk
hugovk merged commit 4f43ade into python:mainSep 7, 2025
12 checks passed
@StanFromIreland
StanFromIreland deleted the localize-theme branch September 7, 2025 17:26
@StanFromIrelandStanFromIreland mentioned this pull request Apr 4, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes
@AA-TurnerAA-TurnerAwaiting requested review from AA-Turner
+2 more reviewers
@rffontenellerffontenellerffontenelle left review comments
@m-aciekm-aciekm-aciek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@StanFromIreland@rffontenelle@hugovk@AA-Turner@m-aciek