Uh oh!
There was an error while loading. Please reload this page.
Update authors in pyproject.toml - #271
Conversation
hugovk
commented
Sep 16, 2025
What's unnecessary, what's incorrect, and why? |
AA-Turner
commented
Sep 16, 2025
I agree with Hugo: when proposing a change, please provide appropriate context and rationale. Here the git blame (at least via the UI) goes back to 788b53d ('Initial version of theme'; Jon Wayne Parrott). I'm on mobile and can't do significant research, but that does probably seem to be an error -- but instead of removing it, shall we change it to say 'python-docs-theme maintainers', or 'python core devs', or whatever? I would prefer to split the Ruff lint rules to a different file (I'm not a fan of putting random config in pyproject.toml), but I know Hugo has differing opinions here. A |
StanFromIreland
commented
Sep 17, 2025
The lint rule exceptions are unnecessary since there are no infractions. The distutils-sig being maintainers of this theme seems incorrect. I can change it to the "Python-docs-theme maintainers" Adam suggests. |
pyproject.tomlpyproject.toml
hugovk
left a comment
There was a problem hiding this comment.
The lint rule exceptions are unnecessary since there are no infractions.
No infractions right now. If we remove the exceptions, a new PR can fail and the author will have to change their code to meet these rules. We don't want that.
Uh oh!
There was an error while loading. Please reload this page.
pyproject.tomlpyproject.tomlUh oh!
There was an error while loading. Please reload this page.
📚 Documentation preview 📚: https://python-docs-theme-previews--271.org.readthedocs.build/