Skip to content

Fix codebgcolor and codetextcolor for Sphinx 3.1.0+ - #57

Merged
pablogsal merged 1 commit into
python:masterfrom
zmwangx:codebgcolor-codetextcolor
Dec 19, 2020
Merged

Fix codebgcolor and codetextcolor for Sphinx 3.1.0+#57
pablogsal merged 1 commit into
python:masterfrom
zmwangx:codebgcolor-codetextcolor

Conversation

@zmwangx

@zmwangxzmwangx commented Oct 10, 2020

Copy link
Copy Markdown
Contributor

Sphinx 3.1.0+ dropped the custom codebgcolor and codetextcolor from the classic theme (see commit sphinx-doc/sphinx@b345acc), leaving pre elements uncolored.

Without the fix:

Screen Shot 2020-10-10 at 11 14 05 AM

Should be:

Screen Shot 2020-10-10 at 11 15 19 AM

@zmwangx
Fix codebgcolor and codetextcolor for Sphinx 3.1.0+
197546f
Sphinx 3.1.0+ dropped the custom codebgcolor and codetextcolor from the classic
theme[1], leaving pre elements uncolored.
[1] sphinx-doc/sphinx@b345acc
zmwangx added a commit to zmwangx/dim that referenced this pull request Oct 10, 2020
@zmwangx
doc: fix codebgcolor and codetextcolor
464b774
See python/python-docs-theme#57.
Also blacken.
@zmwangx

zmwangx commented Oct 10, 2020

Copy link
Copy Markdown
ContributorAuthor

Wait, was this change intentional? Just noticed that Python 3.10 docs, rendered with Sphinx 3.2.1, features background color-less code blocks.

In any case I certainly prefer the old style.

@JulienPalard

JulienPalard commented Oct 10, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Looks related to sphinx-doc/sphinx#7720 / sphinx-doc/sphinx#7721

@zmwangx

zmwangx commented Oct 10, 2020

Copy link
Copy Markdown
ContributorAuthor

Yeah, sphinx-doc/sphinx#7720 led to sphinx-doc/sphinx#7721 led to sphinx-doc/sphinx@b345acc.

@corona10

corona10 commented Oct 17, 2020

Copy link
Copy Markdown
Member

https://bugs.python.org/issue42042

@pablogsal
pablogsal merged commit e77bd1a into python:masterDec 19, 2020
@pablogsal

pablogsal commented Dec 19, 2020•
edited
Loading

Copy link
Copy Markdown
Member

@Mariatta Do you happen to know who has privileges to publish a new version to pypi? We need a new version to restore the colourized backgrounds.

@Mariatta

Mariatta commented Dec 19, 2020

Copy link
Copy Markdown
Member

I can publish this later this evening.

@zmwangx
zmwangx deleted the codebgcolor-codetextcolor branch December 21, 2020 05:27
@Mariatta

Mariatta commented Dec 22, 2020

Copy link
Copy Markdown
Member

We've released v 2020.12
On PyPI: https://pypi.org/project/python-docs-theme/2020.12/
Changelog https://github.com/python/python-docs-theme/releases/tag/v2020.12

@pablogsal

pablogsal commented Dec 22, 2020

Copy link
Copy Markdown
Member

Thanks a lot @Mariatta!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zmwangx@JulienPalard@corona10@pablogsal@Mariatta@the-knights-who-say-ni