Uh oh!
There was an error while loading. Please reload this page.
Update python-docs-theme to work with Sphinx 5 & 6 - #99
Conversation
AA-Turner
commented
Nov 11, 2022
Turns out this is required for Sphinx 5... python/cpython#99381 A |
ezio-melotti
left a comment
There was a problem hiding this comment.
In addition to the inline comments, I have two generic comments:
- The use of semicolons at the end of the line seems inconsistent. Unless there is a specific reason to keep them, I would just remove them all.
- I would avoid the use of
if (...) return;orif (...) break;or evenif (...) some_functions(). The expression after the condition should go on a new line, and it should be surrounded by{ }, e.g.:if(...){ ... }
Fun fact: I originally implemented both the collapsible sidebar (~12 years ago in python/cpython#47393) and the copybutton (~11 years ago in python/cpython@59dba38) and since then they have traveled around a number of dirs and repos. It's nice to see that in the meanwhile things got standardized and JS evolved to the point that JQuery is no longer needed.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
hugovk
commented
Feb 6, 2023
Is this ready to merge? |
hugovk
commented
Feb 13, 2023
Rebased on And there's an error in the console: From the last line of: constbodyWrapper=document.getElementsByClassName("bodywrapper")[0]constsidebar=document.getElementsByClassName("sphinxsidebar")[0]constsidebarWrapper=document.getElementsByClassName('sphinxsidebarwrapper')[0]constsidebarButton=document.getElementById("sidebarbutton")constsidebarArrow=sidebarButton.querySelector('span') |
AA-Turner
commented
Apr 11, 2023
Updated the JavaScript, the previous version was attempting to access an element that had yet to be created. Thank you for the review! A |
python-docs-theme to work with Sphinx 5 & 6JulienPalard
commented
Apr 13, 2023
I just built https://docs.python.org/3.12/ after merging this PR. |
AA-Turner
commented
Apr 13, 2023
Working for me in Firefox 112 on Windows! If you have time over the next few weeks, please would we be able to make a A |
Releasing: #126 |
Updated remaining jQuery scripts to standard JavaScript, and a few fixes for CSS changes.
A