Skip to content

Add PyLong Import/Export API - #121

Merged
vstinner merged 6 commits into
python:mainfrom
skirpichev:long_import-export
Dec 13, 2024
Merged

Add PyLong Import/Export API#121
vstinner merged 6 commits into
python:mainfrom
skirpichev:long_import-export

Conversation

@skirpichev

@skirpichevskirpichev commented Nov 14, 2024•
edited
Loading

Copy link
Copy Markdown
Member

PyPy is not supported, as well as Py2. In the later case it's possible, but hardly worth code complications: most real-word potential consumers (e.g. Sage, gmpy2 or python-flint) support only Python 3.

@skirpichevskirpichev mentioned this pull request Nov 15, 2024
Closed
@skirpichev
Add PyLong Import/Export API
2337b1f
PyPy is not supported, as well as Py2. In the later case it's possible,
but hardly worth code complications: most real-word potential consumers
(e.g. Sage, gmpy2 or python-flint) support only Python 3.
@skirpichev
skirpichev marked this pull request as ready for review December 9, 2024 01:03
@skirpichevskirpichev mentioned this pull request Dec 11, 2024
Closed
@vstinner

vstinner commented Dec 13, 2024

Copy link
Copy Markdown
Member

python/cpython#121339 was merged. What's the status of this PR? Is it up to date and ready to be reviewed?

vstinner
vstinner reviewed Dec 13, 2024
View reviewed changes
Comment threadpythoncapi_compat.h Outdated
Comment threaddocs/changelog.rst Outdated
Comment threadpythoncapi_compat.h Outdated
Comment threadpythoncapi_compat.h Outdated
Comment threadpythoncapi_compat.h Outdated
Comment threadtests/test_pythoncapi_compat_cext.c
Comment threadtests/test_pythoncapi_compat_cext.c Outdated
@skirpichev@vstinner
Apply suggestions from code review
6298821
Co-authored-by: Victor Stinner <vstinner@python.org>
skirpichev
skirpichev commented Dec 13, 2024
View reviewed changes

@skirpichevskirpichev left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it up to date and ready to be reviewed?

It's now slightly outdated. PyLongWriter_Create() should reject ndigits==0; export_long should be set to 0 on errors. I'll address this today.

(Unfortunately, I still don't know how implement this for PyPy (not in RPython, but within this project).)

Comment threaddocs/changelog.rst Outdated
skirpichev
skirpichev commented Dec 13, 2024
View reviewed changes
Comment threadtests/test_pythoncapi_compat_cext.c Outdated
@vstinner
vstinner merged commit 61709bf into python:mainDec 13, 2024
@vstinner

vstinner commented Dec 13, 2024

Copy link
Copy Markdown
Member

Merged, thank you.

@skirpichev
skirpichev deleted the long_import-export branch December 13, 2024 14:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skirpichev@vstinner