Skip to content

Add PyUnstable_TryIncref and PyUnstable_EnableTryIncRef. - #159

Merged
vstinner merged 4 commits into
python:mainfrom
colesbury:try_incref
Nov 5, 2025
Merged

Add PyUnstable_TryIncref and PyUnstable_EnableTryIncRef.#159
vstinner merged 4 commits into
python:mainfrom
colesbury:try_incref

Conversation

@colesbury

@colesburycolesbury commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

These would be useful in PyTorch, which uses pythoncapi-compat.h. They are also already used in pybind11, which doesn't use pythoncapi-compat.h.

vstinner
vstinner reviewed Nov 5, 2025
View reviewed changes
Comment threadpythoncapi_compat.h
Comment threadtests/test_pythoncapi_compat_cext.c Outdated
return -1;
}
#endif
MyType.tp_name = "MyType";

@vstinnervstinnerNov 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use a less generic name, such as TryIncrefType? (for the variable name and the type name)

Comment threadpythoncapi_compat.h
Comment threadpythoncapi_compat.h
Comment threadpythoncapi_compat.h
Comment threadpythoncapi_compat.h Outdated
@vstinner

vstinner commented Nov 5, 2025

Copy link
Copy Markdown
Member

I'm fine with adding these two functions. I just have some suggestions on the implementation.

colesburyand others added 2 commits November 5, 2025 16:44
@colesbury@vstinner
Apply suggestions from code review
6240ab3
Co-authored-by: Victor Stinner <vstinner@python.org>
@colesbury
Rename MyType to TryIncrefType
ac639f6
vstinner
vstinner reviewed Nov 5, 2025
View reviewed changes
Comment threadtests/test_pythoncapi_compat_cext.c Outdated
static int MyObject_dealloc_called = 0;

static void
MyObject_dealloc(PyObject *op)

@vstinnervstinnerNov 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to rename it to TryIncref_dealloc() and rename also MyObject_dealloc_called?

@vstinner
vstinner merged commit c44469c into python:mainNov 5, 2025
36 checks passed
@vstinner

vstinner commented Nov 5, 2025

Copy link
Copy Markdown
Member

Merged, thanks for your contribution.

@colesbury
colesbury deleted the try_incref branch November 5, 2025 22:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@colesbury@vstinner