Skip to content

Ensure README changes don't affect whitespace - #296

Merged
hugovk merged 4 commits into
mainfrom
readme-whitespace
Nov 12, 2025
Merged

Ensure README changes don't affect whitespace#296
hugovk merged 4 commits into
mainfrom
readme-whitespace

Conversation

@AA-Turner

@AA-TurnerAA-Turner commented Oct 21, 2025

Copy link
Copy Markdown
Member

str.splitlines() doesn't preserve trailing lines (unless using keepends=True), whereas str.split('\n') does. Use the latter form, and assert that modified files end with a blank line in tests.

A

@AA-Turner
AA-Turner requested a review from hugovkOctober 21, 2025 12:36
@AA-TurnerAA-Turner mentioned this pull request Oct 21, 2025
Merged
hugovk
hugovk reviewed Oct 24, 2025
View reviewed changes
Comment threadrelease.py Outdated
Comment threadtests/test_release.py Outdated
Comment threadtests/test_release.py Outdated
AA-Turnerand others added 3 commits November 12, 2025 16:30
@AA-Turner@hugovk
no need for encoding arg
5a23a36
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@AA-Turner@hugovk
ditto
06b3be7
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@AA-Turner@hugovk
and again
df608d0
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
hugovk approved these changes Nov 12, 2025
View reviewed changes

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk
hugovk merged commit c0f574f into mainNov 12, 2025
19 checks passed
@hugovk
hugovk deleted the readme-whitespace branch November 12, 2025 17:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AA-Turner@hugovk