Uh oh!
There was an error while loading. Please reload this page.
Use Github Actions + cibuildwheel for all wheels - #163
Conversation
hugovk
left a comment
There was a problem hiding this comment.
Very good!
AppVeyor was running the tests, should GHA run tests too?
And can .travis.yml be removed?
| on: | ||
| push: | ||
| branches: [master] |
There was a problem hiding this comment.
I recommend removing this branch restriction, so contributors can test their feature branches before opening PRs.
Relatedly, do you have an example build?
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hauntsaninja
commented
Oct 11, 2021
Thanks for the feedback! Example build here: https://github.com/hauntsaninja/typed_ast/actions/runs/1327600384 |
hugovk
left a comment
There was a problem hiding this comment.
Looks good!
It's also possible to upload the sdist+wheels to PyPI as part of a release (e.g. tag) using something like https://github.com/pypa/gh-action-pypi-publish, but I'd suggest leaving that for a followup and making a release first with this.
Besides reducing the number of places wheels end up, cibuildwheel does nice things like run auditwheel for you. We also run check-manifest so our sdist is more reliably packaged. Updates to documentation.