Skip to content

Update typing-extensions; some 3.12 updates - #10200

Merged
JelleZijlstra merged 26 commits into
python:mainfrom
JelleZijlstra:newte
May 24, 2023
Merged

Update typing-extensions; some 3.12 updates#10200
JelleZijlstra merged 26 commits into
python:mainfrom
JelleZijlstra:newte

Conversation

@JelleZijlstra

@JelleZijlstraJelleZijlstra commented May 23, 2023

Copy link
Copy Markdown
Member

No description provided.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra

JelleZijlstra commented May 23, 2023

Copy link
Copy Markdown
MemberAuthor

@rchen152 could you take a look at the failure in https://github.com/python/typeshed/actions/runs/5052177791/jobs/9064782798?pr=10200 ? Feels like it has something to do with from typing import TypeVar as _TypeVar.

@JelleZijlstraJelleZijlstra mentioned this pull request May 23, 2023
Merged
@JelleZijlstra

JelleZijlstra commented May 23, 2023

Copy link
Copy Markdown
MemberAuthor

Split out the AST changes into #10201, as they're independent from the rest of the changes and less urgent to get in.

@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood reviewed May 23, 2023
View reviewed changes
Comment threadstdlib/typing.pyi
Comment threadstdlib/typing_extensions.pyi
AlexWaygood
AlexWaygood previously approved these changes May 23, 2023
View reviewed changes
Comment threadstdlib/_collections_abc.pyi
@AlexWaygood
AlexWaygood dismissed their stale reviewMay 23, 2023 13:20

collections.abc.Buffer.buffer should be abstract

@JelleZijlstra@AlexWaygood
Update stdlib/_collections_abc.pyi
50af9b4
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood reviewed May 23, 2023
View reviewed changes
Comment threadstdlib/_collections_abc.pyi
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra@AlexWaygood
Update stdlib/_collections_abc.pyi
2bb54f0
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood reviewed May 23, 2023
View reviewed changes
Comment threadstdlib/typing.pyi Outdated
Comment threadstdlib/typing.pyi
Comment threadstdlib/typing_extensions.pyi
AlexWaygood
AlexWaygood approved these changes May 24, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actionsBot commented May 24, 2023

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra
JelleZijlstra merged commit e4dcfcc into python:mainMay 24, 2023
@JelleZijlstra
JelleZijlstra deleted the newte branch May 24, 2023 18:06
@JelleZijlstra
JelleZijlstra restored the newte branch September 10, 2024 23:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JelleZijlstra@AlexWaygood