Skip to content

TemporaryFile(): Handle one more case correctly - #10284

Merged
JelleZijlstra merged 8 commits into
python:mainfrom
srittau:tempfile-ret2
Jun 14, 2023
Merged

TemporaryFile(): Handle one more case correctly#10284
JelleZijlstra merged 8 commits into
python:mainfrom
srittau:tempfile-ret2

Conversation

@srittau

@srittausrittau commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator

Also add tests.

@srittausrittau mentioned this pull request Jun 8, 2023
Closed
@srittau

srittau commented Jun 8, 2023

Copy link
Copy Markdown
CollaboratorAuthor

I verified the test types against runtime.

AlexWaygood
AlexWaygood reviewed Jun 8, 2023
View reviewed changes
Comment threadstdlib/tempfile.pyi Outdated
@github-actions

This comment has been minimized.

Sign in to view
Akuli
Akuli reviewed Jun 8, 2023
View reviewed changes
Comment threadtest_cases/stdlib/check_tempfile.py Outdated
@github-actions

github-actionsBot commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau

srittau commented Jun 14, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Could I ping this again? Seems like a simple enough fix and is a prerequisite for deciding what to do with #10229.

@JelleZijlstra
JelleZijlstra merged commit 5f9d05c into python:mainJun 14, 2023
@srittau
srittau deleted the tempfile-ret2 branch June 14, 2023 12:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments
@AkuliAkuliAkuli left review comments
@AlexWaygoodAlexWaygoodAlexWaygood left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@srittau@JelleZijlstra@Akuli@AlexWaygood