inspect: getmodulename takes a PathLike

[hauntsaninja]

Fixes#10328

[AlexWaygood]

It also accepts str. We should use _typeshed.StrPath

Suggested change

	defgetmodulename(path: PathLike[str]) ->str|None: ...
	defgetmodulename(path: StrPath) ->str|None: ...

[hauntsaninja]

Oh oof, thanks for the review!

[jaraco]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

There's code this will affect that's expected to land in importlib_metadata soon. Will that help?

[AlexWaygood]

LGTM

[github-actions]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

[AlexWaygood]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

There's code this will affect that's expected to land in importlib_metadata soon. Will that help?

It's okay, we agree that inspect.getmodulename takes path-like objects; I think we're good to go on this :-)

[hauntsaninja]

Thanks, I'll add importlib_metadata to the primer corpus! I was just a little sad my initial mistake wasn't flagged

[jaraco]

Thanks, I'll add importlib_metadata to the primer corpus! I was just a little sad my initial mistake wasn't flagged

Good point. Does that mean that there are no uses in the primer of getmodulename(str)? That's a little surprising. The importlib_metadata changes won't help with that as they'll be passing a subclass of pathlib.PurePosixPath.

[jaraco]

Big thanks for the quick turnaround!