Skip to content

Bump aiofiles to 23.2.* - #10584

Merged
AlexWaygood merged 8 commits into
python:mainfrom
srittau:aiofiles-23.2
Aug 16, 2023
Merged

Bump aiofiles to 23.2.*#10584
AlexWaygood merged 8 commits into
python:mainfrom
srittau:aiofiles-23.2

Conversation

@srittau

@srittausrittau commented Aug 15, 2023

Copy link
Copy Markdown
Collaborator

Closes: #10551

@github-actions

This comment has been minimized.

Sign in to view
@AlexWaygood

AlexWaygood commented Aug 15, 2023

Copy link
Copy Markdown
Member

The runtime might include the symbols in __all__ on Windows even though it doesn't actually define them at runtime on Windows, which is a recipe for confusing our test suite

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@srittausrittau mentioned this pull request Aug 15, 2023
Merged
@srittau

srittau commented Aug 15, 2023

Copy link
Copy Markdown
CollaboratorAuthor

I've disabled stubtest for now. Alternatively we could remove __all__ from the stubs, but hopefully this will get fixed upstream.

@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood reviewed Aug 15, 2023
View reviewed changes
Comment threadstubs/aiofiles/METADATA.toml Outdated
# Currently we are in a pickle, because aiofiles.os.__all__ is incorrect at
# runtime when running on win32. (https://github.com/Tinche/aiofiles/pull/174)
# This means that stubtest is either correct on Windows or all other platforms.
skip = true

@AlexWaygoodAlexWaygoodAug 15, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely we don't need to skip stubtest entirely for the whole package. Can't we just create a stubtest_allowlist_win32.txt file in the @tests directory with three allowlist entries, aiofiles.os.__all__, aiofiles.os.sendfile and aiofiles.os.statvfs?

@srittausrittauAug 16, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know we could have architecture-specific allowlists! Will change accordingly.

@AlexWaygoodAlexWaygoodAug 16, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of @Avasam's innovations :)

@srittausrittauAug 16, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Embarrassingly, aiofiles already has architecture-specific allowlists ... 😳

@AlexWaygoodAlexWaygoodAug 16, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of @Avasam's innovations :)

Oh, it was @sobolevn's PR, so he deserves most of the credit! #8923 Though @Avasam pushed for the change

@AvasamAvasamAug 16, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it was @sobolevn's PR, so he deserves most of the credit! #8923 Though @Avasam pushed for the change

Exact :) I opened an issue for discussion (#8660), fixed a couple edge cases (like #9173) and updated plenty of stubs afterwards.

AlexWaygood
AlexWaygood reviewed Aug 16, 2023
View reviewed changes
Comment threadstubs/aiofiles/@tests/stubtest_allowlist_win32.txt
@srittau@AlexWaygood
Update stubs/aiofiles/@tests/stubtest_allowlist_win32.txt
227917d
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood approved these changes Aug 16, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions

github-actionsBot commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood
AlexWaygood merged commit 695d41f into python:mainAug 16, 2023
@srittau
srittau deleted the aiofiles-23.2 branch August 16, 2023 11:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AvasamAvasamAvasam left review comments
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@srittau@AlexWaygood@Avasam