Uh oh!
There was an error while loading. Please reload this page.
py313: mark Linux-only decimal allowlist entries as unfixable for now - #12061
Conversation
68b050f to
a72a2baCompare
This comment has been minimized.
This comment has been minimized.
1fb52b8 to
5c1a69fCompare369ade3 to
124f709CompareI think the parameter names changing only on Linux indicates that the |
AlexWaygood
commented
May 30, 2024
I suggest that instead of trying to "fix" the Linux-only allowlist entries here, we move them to a separate section of the allowlist with a comment explaining why we shouldn't try to fix them at this point in time. |
This comment has been minimized.
This comment has been minimized.
aminalaee
commented
May 30, 2024
Yeah I think that makes sense, I initially started this PR to double-check what I'm seeing is right. I didn't want to start another discussion in the CPython repo (yet) 😅 |
It definitely seems like the @erlend-aasland, would you be able to clarify that at all? python/cpython#115119 is a long issue thread, and I'm not quite sure what the status is right now, as a non-expert in CPython's build system 😄 I don't want to open a bug report at |
erlend-aasland
commented
May 30, 2024
3.13.0b2 build system will fall back to the CPython vendored (but deprecated) libmpdecimal library, so unlike 3.13.0b1, 3.13.0b2 should have the See also: |
Thanks so much @erlend-aasland! @aminalaee, for the Linux-only stubtest allowlist entries, let's just do what I suggested in #12061 (comment) for now, in that case, since the allowlist entries will all go away naturally when we start using beta2 in CI :-) |
This reverts commit 124f709.
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Just to test with the pipeline