Skip to content

Accept __getitem__-iterables in builtins.enumerate#12294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jorenham wants to merge 6 commits into from
Closed

Accept __getitem__-iterables in builtins.enumerate#12294

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
29bbecd
consider both `Iterable` and `_GetItemIterable` as "iterand" types
jorenham Jul 9, 2024
2357e03
only accept `_GetItemIterable` in collection type constructors and `i…
jorenham Jul 10, 2024
57dfa41
Update stdlib/builtins.pyi
JelleZijlstra Jul 10, 2024
4cb2815
only accept `_GetItemIterable` in `enumerate` and `iter`
jorenham Jul 10, 2024
37c95e6
use `typing.overload` in `enumerate.__new__` for `_GetItemIterable` f…
jorenham Jul 10, 2024
20a712d
Revert "use `typing.overload` in `enumerate.__new__` for `_GetItemIte…
jorenham Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions stdlib/builtins.pyi
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -929,6 +929,9 @@ class slice:
__hash__: ClassVar[None] # type: ignore[assignment]
def indices(self, len: SupportsIndex, /) -> tuple[int, int, int]: ...

class _GetItemIterable(Protocol[_T_co]):
def __getitem__(self, i: int, /) -> _T_co: ...

class tuple(Sequence[_T_co]):
def __new__(cls, iterable: Iterable[_T_co] = ..., /) -> Self: ...
def __len__(self) -> int: ...
Expand DownExpand Up@@ -1188,7 +1191,7 @@ class frozenset(AbstractSet[_T_co]):
def __class_getitem__(cls, item: Any, /) -> GenericAlias: ...

class enumerate(Iterator[tuple[int, _T]]):
def __new__(cls, iterable: Iterable[_T], start: int = ...) -> Self: ...
def __new__(cls, iterable: Iterable[_T] | _GetItemIterable[_T], start: int = ...) -> Self: ...
def __iter__(self) -> Self: ...
def __next__(self) -> tuple[int, _T]: ...
if sys.version_info >= (3, 9):
Expand DownExpand Up@@ -1417,10 +1420,6 @@ def help(request: object = ...) -> None: ...
def hex(number: int | SupportsIndex, /) -> str: ...
def id(obj: object, /) -> int: ...
def input(prompt: object = "", /) -> str: ...

class _GetItemIterable(Protocol[_T_co]):
def __getitem__(self, i: int, /) -> _T_co: ...

@overload
def iter(object: SupportsIter[_SupportsNextT], /) -> _SupportsNextT: ...
@overload
Expand Down