Uh oh!
There was an error while loading. Please reload this page.
improve identity of threading module's Lock and RLock - #12966
Merged
Conversation
tungol
marked this pull request as draft
November 6, 2024 23:38
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tungol
commented
Nov 6, 2024
ContributorAuthor
The unused ignore is from |
tungol
marked this pull request as ready for review
November 6, 2024 23:57
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Diff from mypy_primer, showing the effect of this PR on open source code: discord.py (https://github.com/Rapptz/discord.py)
- discord/webhook/sync.py:153: error: Incompatible types in assignment (expression has type "DeferredLock", variable has type "Lock") [assignment]+ discord/webhook/sync.py:153: error: Incompatible types in assignment (expression has type "DeferredLock", variable has type "LockType") [assignment]- discord/webhook/sync.py:197: error: "Lock" has no attribute "delay_by" [attr-defined]+ discord/webhook/sync.py:197: error: "LockType" has no attribute "delay_by" [attr-defined]
dd-trace-py (https://github.com/DataDog/dd-trace-py)
+ ddtrace/profiling/collector/threading.py:43: error: Unused "type: ignore" comment [unused-ignore] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes extra copy of the type, although I did immediately add back a different extra copy for the minor benefit of getting the name
_thread.lockcorrect on 3.13+. We can call it even, I guess.