Skip to content

add _GeneratorContextManagerBase.__init__ - #13246

Merged
JelleZijlstra merged 7 commits into
python:mainfrom
tungol:_GeneratorContextManagerBase
Dec 28, 2024
Merged

add _GeneratorContextManagerBase.__init__#13246
JelleZijlstra merged 7 commits into
python:mainfrom
tungol:_GeneratorContextManagerBase

Conversation

@tungol

Copy link
Copy Markdown
Contributor

I think that #6676 showed that Paramspec didn't work, but that wasn't actually the fault of _GeneratorContextManagerBase.

We'll see what mypy-primer has to say about it.

I think that python#6676 showed that Paramspec didn't work, but that
wasn't actually the fault of _GeneratorContextManagerBase.
@tungol
tungolforce-pushed the _GeneratorContextManagerBase branch from b4acb0e to bf795a1CompareDecember 14, 2024 03:11
@tungol
tungol marked this pull request as draft December 14, 2024 03:12
@tungoltungol closed this Dec 14, 2024
@github-actions

This comment has been minimized.

@tungoltungol reopened this Dec 14, 2024
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@tungol
tungol marked this pull request as ready for review December 14, 2024 05:23
@github-actions

This comment has been minimized.

@tungol

Copy link
Copy Markdown
ContributorAuthor

Ah, well, that's no good then.

@tungol
tungolforce-pushed the _GeneratorContextManagerBase branch from ca85887 to 01ee3d5CompareDecember 14, 2024 07:19
@github-actions

This comment has been minimized.

Comment threadstdlib/contextlib.pyi Outdated
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

pyinstrument (https://github.com/joerick/pyinstrument)
- pyinstrument/vendor/decorator.py:295: error: Incompatible types in assignment (expression has type "Callable[[Any, Any, VarArg(Any), KwArg(Any)], Any]", variable has type "Callable[[_GeneratorContextManager[_T_co], Callable[..., Iterator[_T_co]], tuple[Any, ...], dict[str, Any]], None]") [assignment]+ pyinstrument/vendor/decorator.py:295: error: Incompatible types in assignment (expression has type "Callable[[Any, Any, VarArg(Any), KwArg(Any)], Any]", variable has type "Callable[[_GeneratorContextManagerBase[_G], Callable[..., _G], tuple[Any, ...], dict[str, Any]], None]") [assignment]- pyinstrument/vendor/decorator.py:301: error: Incompatible types in assignment (expression has type "Callable[[Any, Any, VarArg(Any), KwArg(Any)], Any]", variable has type "Callable[[_GeneratorContextManager[_T_co], Callable[..., Iterator[_T_co]], tuple[Any, ...], dict[str, Any]], None]") [assignment]+ pyinstrument/vendor/decorator.py:301: error: Incompatible types in assignment (expression has type "Callable[[Any, Any, VarArg(Any), KwArg(Any)], Any]", variable has type "Callable[[_GeneratorContextManagerBase[_G], Callable[..., _G], tuple[Any, ...], dict[str, Any]], None]") [assignment]

@JelleZijlstra
JelleZijlstra merged commit 43f637b into python:mainDec 28, 2024
@tungol
tungol deleted the _GeneratorContextManagerBase branch December 28, 2024 04:50
@cdce8pcdce8p mentioned this pull request Jan 1, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tungol@JelleZijlstra