Enable Ruff PERF

[Avasam]

Ref #13295
https://docs.astral.sh/ruff/rules/#perflint-perf

That manual-list-comprehension (PERF401)initially looked like a false-positive I just had to add a parenthesis and make everything list comprehensions. I'll let the numbers talk for themselves in comments.

About try-except-in-loop (PERF203), here's prior conversation with @AlexWaygood : astral-sh/ruff#12805 (comment)

[Avasam]

Test:

importtimeitsetup="""from itertools import chainproject_urls = { "Changelog": "https://code.qt.io/cgit/pyside/pyside-setup.git/tree/doc/changelogs", "Documentation": "https://doc.qt.io/qtforpython", "Homepage": "https://pyside.org", "Repository": "https://code.qt.io/cgit/pyside/pyside-setup.git/", "Tracker": "https://bugreports.qt.io/projects/PYSIDE",}url_names_probably_pointing_to_source = ("Source", "Repository", "Homepage")"""stmt="""urls_to_check: list[str] = []for url_name in url_names_probably_pointing_to_source: if url := project_urls.get(url_name): urls_to_check.append(url)urls_to_check.extend( url for url_name, url in project_urls.items() if url_name not in url_names_probably_pointing_to_source)for url in urls_to_check: pass"""print(timeit.timeit(stmt=stmt, setup=setup))
stmt="""urls_to_check: list[str] = []for url_name in url_names_probably_pointing_to_source: if url := project_urls.get(url_name): urls_to_check.append(url)urls_to_check.extend( [url for url_name, url in project_urls.items() if url_name not in url_names_probably_pointing_to_source])for url in urls_to_check: pass"""print(timeit.timeit(stmt=stmt, setup=setup))
stmt="""project_urls_probably_pointing_to_source = ( project_urls.get(url_name) for url_name in url_names_probably_pointing_to_source)urls_to_check = chain( (url for url in project_urls_probably_pointing_to_source if url), (url for url_name, url in project_urls.items() if url_name not in url_names_probably_pointing_to_source),)for url in urls_to_check: pass"""print(timeit.timeit(stmt=stmt, setup=setup))
stmt="""project_urls_probably_pointing_to_source = [project_urls.get(url_name) for url_name in url_names_probably_pointing_to_source]urls_to_check = ( [url for url in project_urls_probably_pointing_to_source if url] + [url for url_name, url in project_urls.items() if url_name not in url_names_probably_pointing_to_source])for url in urls_to_check: pass"""print(timeit.timeit(stmt=stmt, setup=setup))

Results (Python 3.10):

0.68677179999940560.6101396999983990.92887759999939590.7600129999991623

Results (Python 3.13):

0.74357270000109570.53912350000246080.99498630000016420.5781141000006755

[Avasam]

Nevermind, I was just missing parenthesis: astral-sh/ruff#15047 (comment)
(new run time on python 3.13 is 0.5153441999973438)

[hauntsaninja]

This is harder to read. In general, I'm not sure we need this level of linting on typeshed

[Avasam]

I'd prefer formatting as follow but Black doesn't allow:

urls_to_check= (
[urlforurl_nameinurl_names_probably_pointing_to_sourceif (url:=project_urls.get(url_name))]
+ [urlforurl_name, urlinproject_urls.items() ifurl_namenotinurl_names_probably_pointing_to_source]
)

[AlexWaygood]

I don't feel like anything in typeshed is performance-critical such that we need to worry about micro-optimising specific functions in our tests; I agree that these rules don't really make sense for this repository

[AlexWaygood]

From the comments and upvotes here, I think there's sufficient opposition from the core team here that we probably won't be going ahead with this one :-)