Uh oh!
There was an error while loading. Please reload this page.
dest argument to add_argument is Optional - #2040
Conversation
argparse.py checks for None in _get_optional_kwargs.
JelleZijlstra
commented
Apr 11, 2018
See https://github.com/python/cpython/blob/master/Lib/argparse.py#L1476. This fixes a CI failure introduced by #1937. |
gvanrossum
commented
Apr 11, 2018
Hm, what a pain. If I sync typeshed to this (after it's been merged) and cherry-pick the sync into the release-0.590 branch, I get a whole slew of extra typeshed PRs into the bargain. To play it safe I would have to create a typeshed release branch and cp this into that, then sync that branch into mypy. It's doable, but a bit convoluted. OTOH perhaps I'm being overly cautious. Let me see if just syncing to typeshed HEAD (after this) breaks anything in the Dropbox codebase. |
JelleZijlstra
commented
Apr 11, 2018
JelleZijlstra
commented
Apr 11, 2018
The Travis failure here is just because the branch I used doesn't have #2039. This PR should be safe to merge. |
gvanrossum
commented
Apr 11, 2018
via email
Yeah, I'm going to have to cp just the fix for #2039 -- the argparse
changes do break our internal codebase, and I don't want to have to sort
that out under time pressure. |
argparse.py checks for None in _get_optional_kwargs.
argparse.py checks for None in _get_optional_kwargs.