Skip to content

Stop inheriting Sized in collection ABCs - #2658

Merged
gvanrossum merged 4 commits into
masterfrom
expunge-sized-from-typing
Nov 30, 2018
Merged

Stop inheriting Sized in collection ABCs#2658
gvanrossum merged 4 commits into
masterfrom
expunge-sized-from-typing

Conversation

@gvanrossum

@gvanrossumgvanrossum commented Nov 30, 2018

Copy link
Copy Markdown
Member

Instead define abstract len in affected classes.

Fixes#2655 without breaking
rominf/ordered-set-stubs#1

Guido van Rossum
Stop inheriting Sized in collection ABCs
0e3750e
Instead define abstract __len__ in affected classes.
Fixes#2655 without breaking
rominf/ordered-set-stubs#1
JukkaL
JukkaL reviewed Nov 30, 2018
View reviewed changes
Comment threadstdlib/2/typing.pyi Outdated
JukkaL
JukkaL reviewed Nov 30, 2018
View reviewed changes
Comment threadstdlib/3/typing.pyi Outdated
def __len__(self) -> int: ...

class Sequence(_Collection[_T_co], Reversible[_T_co], Generic[_T_co]):
class Sequence(Iterable[_T_co], Container[_T_co], Reversible[_T_co], Generic[_T_co]):

@JukkaLJukkaLNov 30, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe preserve _Collection here, as otherwise mypy could infer a less precise type for some type joins? Then you could leave out __len__ as it would be inherited.

JukkaL
JukkaL reviewed Nov 30, 2018
View reviewed changes
Comment threadstdlib/3/typing.pyi Outdated
JukkaL
JukkaL reviewed Nov 30, 2018
View reviewed changes
Comment threadstdlib/3/typing.pyi Outdated
@srittau

srittau commented Nov 30, 2018

Copy link
Copy Markdown
Collaborator

You declare __len__() to be abstract in this patch. While this looks correct to me, I wonder why the other methods in those types are not declared to be abstract. Should we add @abstractmethod to those (in a separate PR), is @abstractmethod wrong for __len__() as well or is there a reason to treat them differently?

@JukkaL

JukkaL commented Nov 30, 2018

Copy link
Copy Markdown
Contributor

Some of the ABCs define various concrete methods that can act as default implementations.

@gvanrossumgvanrossum mentioned this pull request Nov 30, 2018
Closed
@gvanrossum
gvanrossum merged commit de50614 into masterNov 30, 2018
@gvanrossum
gvanrossum deleted the expunge-sized-from-typing branch November 30, 2018 21:10
@gvanrossumgvanrossum mentioned this pull request Nov 30, 2018
Merged
gvanrossum added a commit to python/mypy that referenced this pull request Nov 30, 2018
@gvanrossum
Sync typeshed (#5981)
18d4325
To incorporate python/typeshed#2658
gvanrossum added a commit to python/mypy that referenced this pull request Nov 30, 2018
@gvanrossumGuido van Rossum
Sync typeshed (#5981)
c654871
To incorporate python/typeshed#2658
@ilevkivskyiilevkivskyi mentioned this pull request Dec 9, 2018
Closed
yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
@gvanrossumJiri Suchan
Stop inheriting Sized in collection ABCs (python#2658)
dfc83de
Instead define abstract __len__ in affected classes.
Fixespython#2655 without breaking
rominf/ordered-set-stubs#1
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JukkaLJukkaLJukkaL left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gvanrossum@srittau@JukkaL