Uh oh!
There was an error while loading. Please reload this page.
Fix stab for TextIOBase.detach() and add stab for TextIOWrapper.buffer - #4036
Conversation
| def __init__( | ||
| self, | ||
| buffer: IO[bytes], | ||
| buffer: BinaryIO, |
There was a problem hiding this comment.
I believe CI fails due to this change. Honestly, I would just leave this instance as IO[bytes] for now. In the future it might make sense to make TextIOWrapper generic over the buffer, but I haven't looked at it in depth.
hauntsaninja
commented
May 18, 2020
As it happens, I just removed that particular sample from mypy (python/mypy#8838), so if you re-run CI it should pass. |
srittau
commented
May 18, 2020
I'm re-running it. It would be great if someone with a large typed code base (hey Dropbox team) could check this, though. Our internal code base doesn't use |
srittau
left a comment
There was a problem hiding this comment.
Ok, let's try this out. If it breaks anything, we can always partly revert before the next mypy release.
Closes#3993.